fix(core): frame ignored event listeners in xml markup (NativeScript#10646)

CatchABus · web-flow · commit 750d2ee45578 · 2024-11-18T19:50:21.000-08:00
diff --git a/packages/core/ui/frame/frame-common.ts b/packages/core/ui/frame/frame-common.ts
@@ -35,7 +35,8 @@ function buildEntryFromArgs(arg: any): NavigationEntry {
 
 @CSSType('Frame')
 export class FrameBase extends CustomLayoutView {
-	public static androidOptionSelectedEvent = 'optionSelected';
+	public static navigatingToEvent = 'navigatingTo';
+	public static navigatedToEvent = 'navigatedTo';
 
 	private _animated: boolean;
 	private _transition: NavigationTransition;
@@ -267,7 +268,7 @@ export class FrameBase extends CustomLayoutView {
 
 		newPage.onNavigatedTo(isBack);
 		this.notify({
-			eventName: Page.navigatedToEvent,
+			eventName: FrameBase.navigatedToEvent,
 			object: this,
 			isBack,
 			entry,
@@ -452,7 +453,7 @@ export class FrameBase extends CustomLayoutView {
 
 		backstackEntry.resolvedPage.onNavigatingTo(backstackEntry.entry.context, isBack, backstackEntry.entry.bindingContext);
 		this.notify({
-			eventName: Page.navigatingToEvent,
+			eventName: FrameBase.navigatingToEvent,
 			object: this,
 			isBack,
 			entry: backstackEntry,
diff --git a/packages/core/ui/frame/index.d.ts b/packages/core/ui/frame/index.d.ts
@@ -17,6 +17,16 @@ export interface NavigationData extends EventData {
  * Nested frames are supported, enabling hierarchical navigation scenarios.
  */
 export class Frame extends FrameBase {
+	/**
+	 * String value used when hooking to navigatingTo event.
+	 */
+	public static readonly navigatingToEvent = 'navigatingTo';
+
+	/**
+	 * String value used when hooking to navigatedTo event.
+	 */
+	public static readonly navigatedToEvent = 'navigatedTo';
+
 	/**
 	 * @private
 	 */
