Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metadata-model): adding metadata model doc generation and upload… #3667

Merged
merged 5 commits into from
Dec 5, 2021
Merged

feat(metadata-model): adding metadata model doc generation and upload… #3667

merged 5 commits into from
Dec 5, 2021

Conversation

swaroopjagadish
Copy link
Contributor

… to DataHub

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@swaroopjagadish swaroopjagadish force-pushed the metadata-model-docs branch 2 times, most recently from 2d16979 to 1820291 Compare December 5, 2021 05:32
@swaroopjagadish swaroopjagadish marked this pull request as draft December 5, 2021 05:33
@github-actions
Copy link

github-actions bot commented Dec 5, 2021 •
edited
Loading

Unit Test Results

     44 files  ±0       44 suites  ±0   29m 36s ⏱️ + 2m 51s
   616 tests ±0     564 ✔️ ±0  52 💤 ±0  0 ❌ ±0 
1 355 runs  ±0  1 287 ✔️ ±0  68 💤 ±0  0 ❌ ±0 

Results for commit 73dc09e. ± Comparison against base commit 999e9e5.

♻️ This comment has been updated with latest results.

@swaroopjagadish swaroopjagadish marked this pull request as ready for review December 5, 2021 20:19
shirshanka
shirshanka approved these changes Dec 5, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit a16c432 into datahub-project:master Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swaroopjagadish @shirshanka