Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): don't use /api in gms url #12083

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(cli): don't use /api in gms url #12083

merged 1 commit into from
Dec 11, 2024

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Dec 10, 2024 •
edited
Loading

The correct URL is without /api and many folks add /api in the URL causing problems. This would eliminate those problems

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 10, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 10, 2024
@anshbansal anshbansal merged commit ff7ac48 into master Dec 11, 2024
74 of 101 checks passed
@anshbansal anshbansal deleted the ab-fixup-gms-url branch December 11, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrydal skrydal skrydal approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @skrydal