Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/superset): initial support for superset datasets #11972

Merged
merged 17 commits into from
Dec 6, 2024
Merged

feat(ingest/superset): initial support for superset datasets #11972

merged 17 commits into from
Dec 6, 2024

Conversation

hwmarkcheng
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Description:

First split of this PR: #11688

PR to enrich Superset Ingestion with relevant metadata
Superset has useful metadata in relation to superset physical (Raw table, 1:1 with say redshift table) /virtual (Custom sql) datasets, e.g owners, their own schema fields, custom sql, etc.

The current iteration of superset ingestion simply just links to the schema/table specified in the API (Which can be inaccurate, especially for virtual datasets). We've added a few changes to enrich the ingestion process.

  • Creates Dataset Entity for each physical/virtual dataset in Superset
  • Added Schema fields for charts/datasets

@hwmarkcheng hwmarkcheng marked this pull request as ready for review November 27, 2024 15:26
@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Nov 27, 2024
@hwmarkcheng hwmarkcheng mentioned this pull request Nov 27, 2024
Merged
5 tasks
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 27, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Nov 27, 2024
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Nov 29, 2024
hsheth2
hsheth2 requested changes Nov 29, 2024
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/superset.py Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/superset.py Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/superset.py Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/superset.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/superset.py Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/superset.py Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/superset.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/superset.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/superset.py Outdated Show resolved Hide resolved
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Nov 29, 2024
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Dec 2, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 2, 2024
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Dec 5, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 5, 2024
@hwmarkcheng hwmarkcheng changed the title Base Superset Enrichment Changes feat: Base Superset Enrichment Changes Dec 5, 2024
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter needs-review Label for PRs that need review from a maintainer. labels Dec 5, 2024
@hsheth2 hsheth2 changed the title feat: Base Superset Enrichment Changes feat(ingest/superset): initial support for superset datasets Dec 6, 2024
@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Dec 6, 2024
@hsheth2 hsheth2 merged commit 46aa962 into datahub-project:master Dec 6, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwmarkcheng @hsheth2