feat: Add parent container hierarchy label to the container #11705
Conversation
github-actions
bot
added
product
|
@jjoyce0510 @chriscollins3456 @shirshanka - Please review the PR when you get chance. |
shirshanka
added
the
datahub-community-champion
datahub-cyborg
bot
added
the
needs-review
kanavnarula
changed the title
| icon = newIcon; | ||
| label = newLabel; | ||
| // Scenario where the filter entity exists and filterField is container | ||
| if (filterField === CONTAINER_FILTER_NAME) { |
There was a problem hiding this comment.
please elevate this condition to the same level as
else if (filterField === PLATFORM_FILTER_NAME)
to keep things consistent (instead of nesting it down here)
There was a problem hiding this comment.
Updated the condition
| ) : ( | ||
| entityRegistry.getIcon(EntityType.DataPlatform, size || 12, IconStyleType.ACCENT, ANTD_GRAY[9]) | ||
| ); | ||
| label = entityRegistry.getDisplayName(filterEntity.type, filterEntity); |
There was a problem hiding this comment.
Nice this change looks great!
Thanks @jjoyce0510 for reviewing the PR. Feedback has been addressed. Please review once again when you get time. |
|
@jjoyce0510 - I will fix the linting issues shortly and let you know. |
|
@jjoyce0510 - Feedback has been addressed. Please review when you get time today. |
This is to add parent hierarchy on top of the container name.
Before Advance Filter Container View:
After Advance Filter Container View:
Basic Filter Container View:
Create View Page:
Checklist