Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spark-lineage): enable user with editor role to ingest dataProces… #11130

Merged
merged 6 commits into from
Aug 26, 2024
Merged

fix(spark-lineage): enable user with editor role to ingest dataProces… #11130

merged 6 commits into from
Aug 26, 2024

Conversation

deepgarg-visa
Copy link
Contributor

@deepgarg-visa deepgarg-visa commented Aug 9, 2024 •
edited by coderabbitai bot
Loading

…sInstance Entity

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

  • New Features
    • Added support for the new term "dataProcessInstance" in the system configuration, enhancing functionality to handle data process instances alongside existing terms.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 9, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent update to the policies.json configuration file introduces a new term, "dataProcessInstance," to an existing array of recognized terms. This enhancement expands the system's capability to manage and utilize data process instances, thereby improving overall functionality and adaptability.

Changes

Files Change Summary
metadata-service/.../policies.json Added "dataProcessInstance" to the array of terms.

Poem

🐇✨
In the meadow where data flows,
New terms sprout like blooming roses.
"DataProcessInstance" joins the dance,
Expanding our world, giving us a chance!
With every change, our systems grow,
Hopping forward, watch us go!
✨🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels Aug 9, 2024
coderabbitai[bot]
coderabbitai bot reviewed Aug 9, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 78336c9 and e0b5ea9.

Files selected for processing (1)
  • metadata-service/war/src/main/resources/boot/policies.json (1 hunks)
Additional comments not posted (1)
metadata-service/war/src/main/resources/boot/policies.json (1)

365-366: Confirm the addition of "dataProcessInstance" to resource types.

The addition of "dataProcessInstance" to the list of resource types for editors aligns with the PR objective. Ensure that this change is consistent across the system and supported by existing configurations.

Verification successful

Addition of "dataProcessInstance" is consistent and supported.

The addition of "dataProcessInstance" to the resource types in policies.json is consistent with existing configurations across the system. The entity type is already referenced in various parts of the codebase, indicating system support. No further changes are needed.

  • References found in configuration files, Java classes, and test data confirm support for "dataProcessInstance".
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the system supports "dataProcessInstance" as a resource type.

# Test: Search for configurations or code that reference "dataProcessInstance".
rg --type json --type yaml --type java --type scala 'dataProcessInstance'

Length of output: 103441

@david-leifker david-leifker added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 9, 2024
@anshbansal anshbansal merged commit beb4306 into datahub-project:master Aug 26, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@david-leifker david-leifker david-leifker approved these changes

@RyanHolstien RyanHolstien Awaiting requested review from RyanHolstien

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepgarg-visa @RyanHolstien @david-leifker @anshbansal