Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(gms/scim-api): fix title and add overview #10388

Merged
merged 8 commits into from
May 21, 2024

Conversation

sid-acryl
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the docs Issues and Improvements to docs label Apr 26, 2024
@@ -44,12 +73,14 @@ import FeatureAvailability from '@site/src/components/FeatureAvailability';
<img width="70%" src="https://raw.githubusercontent.com/datahub-project/static-assets/main/imgs/scim/application-registration.png"/>
</p>

Create three roles having `Display Name` and `Value` as mentioned below
Create three roles having `Display Name` and `Value` as mentioned below
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it won't let me inset a suggestion on line 70, but let's add:

d. Create Role: Go back to the app created in Step #1 and go to the Provisioning section and click on application registration. to create the role

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@ethan-cartwright ethan-cartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hsheth2 hsheth2 merged commit 634a486 into datahub-project:master May 21, 2024
26 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and Improvements to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants