Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Looker/Lookml ingestion doesn't support view inheritance #9465

Closed
pedro-iatzky opened this issue Dec 14, 2023 · 3 comments · Fixed by #11148
Closed

Looker/Lookml ingestion doesn't support view inheritance #9465

pedro-iatzky opened this issue Dec 14, 2023 · 3 comments · Fixed by #11148
Assignees
@hsheth2 @sid-acryl
Labels
accepted An Issue that is confirmed as a bug by the DataHub Maintainers. bug Bug report

Comments

@pedro-iatzky
Copy link
Contributor

Describe the bug
Looker/Lookml ingestion does not handle inheritance correctly.
When I extract a view that is extending another the child view does not show the parent dimensions/measures.

To Reproduce
Steps to reproduce the behavior:

  1. Create the following file in Lookml
explore: datahub_test {
  view_name: child_view
}

view: parent_view {
  sql_table_name: `dataset.table` ;;

  dimension: id {
    primary_key: yes
    type: string
    sql: ${TABLE}.id ;;
  }

  dimension: parent_dimension_1 {
    type: string
    sql: ${TABLE}.parent_dimension_1 ;;
  }

  measure: parent_count {
    type: count
  }
}

view: child_view {
  extends: [parent_view]

  dimension: child_dimension_1 {
    type: string
    sql: ${TABLE}.child_dimension_1 ;;
  }
}
  1. Run Lookml & Looker ingestion

Expected behavior
I would expect to see two views extracted. The parent, and the child. Also, the child_view should show the dimensions/measures inherited from parent

Screenshots

image

Additional context
Datahub version: v0.12.0
@pedro-iatzky pedro-iatzky added the bug Bug report label Dec 14, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2024

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

@github-actions github-actions bot added the stale label Feb 4, 2024
@hsheth2
Copy link
Collaborator

hsheth2 commented Feb 7, 2024

This seems like a bug in get_including_extends - for "list" fields like dimension/measure/etc, we need to merge with parent views instead of only fetching the value for the child field

@github-actions github-actions bot removed the stale label Feb 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

@github-actions github-actions bot added the stale label Mar 8, 2024
@hsheth2 hsheth2 added the accepted An Issue that is confirmed as a bug by the DataHub Maintainers. label Mar 8, 2024
@github-actions github-actions bot removed the stale label Mar 9, 2024
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2024
@hsheth2 hsheth2 reopened this Aug 7, 2024
@hsheth2 hsheth2 mentioned this issue Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsheth2 hsheth2

@sid-acryl sid-acryl

Labels
accepted An Issue that is confirmed as a bug by the DataHub Maintainers. bug Bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ingest/lookml): support view inheritance for fields sid-acryl/datahub-fork
3 participants
@hsheth2 @pedro-iatzky @sid-acryl