Skip to content

Commit 0873105

Browse files
authored
feat(ingest): bump acryl-sqlglot dep (#10343)
1 parent 31ae32d commit 0873105

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

metadata-ingestion/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@
9999
sqlglot_lib = {
100100
# Using an Acryl fork of sqlglot.
101101
# https://github.com/tobymao/sqlglot/compare/main...hsheth2:sqlglot:hsheth?expand=1
102-
"acryl-sqlglot==23.2.1.dev5",
102+
"acryl-sqlglot==23.11.2.dev2",
103103
}
104104

105105
classification_lib = {

metadata-ingestion/tests/unit/sql_parsing/goldens/test_select_max_with_schema.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,12 @@
1111
"downstream": {
1212
"table": null,
1313
"column": "max_col",
14-
"column_type": null,
15-
"native_column_type": null
14+
"column_type": {
15+
"type": {
16+
"com.linkedin.pegasus2avro.schema.NumberType": {}
17+
}
18+
},
19+
"native_column_type": "DECIMAL"
1620
},
1721
"upstreams": [
1822
{

metadata-ingestion/tests/unit/sql_parsing/goldens/test_snowflake_default_normalization.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"query_type_props": {
44
"kind": "TABLE"
55
},
6-
"query_fingerprint": "2aa655ab211e061dc8c1161e0b2a7073b38636f9ffcc4719d4e70743e3321cb2",
6+
"query_fingerprint": "58a15c69c357905aec390867335699413678368f321bfde6f477c08a973ca3a9",
77
"in_tables": [
88
"urn:li:dataset:(urn:li:dataPlatform:snowflake,long_tail_companions.analytics.customer_last_purchase_date,PROD)",
99
"urn:li:dataset:(urn:li:dataPlatform:snowflake,long_tail_companions.ecommerce.purchases,PROD)"
@@ -127,6 +127,6 @@
127127
],
128128
"debug_info": {
129129
"confidence": 0.4,
130-
"generalized_statement": "CREATE TABLE active_customer_ltv AS (WITH active_customers AS (SELECT * FROM customer_last_purchase_date WHERE last_purchase_date >= CURRENT_DATE - INTERVAL DAYS), purchases AS (SELECT * FROM ecommerce.purchases) SELECT active_customers.user_fk, active_customers.email, active_customers.last_purchase_date, SUM(purchases.purchase_amount) AS lifetime_purchase_amount, COUNT(DISTINCT (purchases.pk)) AS lifetime_purchase_count, SUM(purchases.purchase_amount) / COUNT(DISTINCT (purchases.pk)) AS average_purchase_amount FROM active_customers JOIN purchases ON active_customers.user_fk = purchases.user_fk GROUP BY ?, ?, ?)"
130+
"generalized_statement": "CREATE TABLE active_customer_ltv AS (WITH active_customers AS (SELECT * FROM customer_last_purchase_date WHERE last_purchase_date >= CURRENT_DATE - INTERVAL '? DAYS'), purchases AS (SELECT * FROM ecommerce.purchases) SELECT active_customers.user_fk, active_customers.email, active_customers.last_purchase_date, SUM(purchases.purchase_amount) AS lifetime_purchase_amount, COUNT(DISTINCT (purchases.pk)) AS lifetime_purchase_count, SUM(purchases.purchase_amount) / COUNT(DISTINCT (purchases.pk)) AS average_purchase_amount FROM active_customers JOIN purchases ON active_customers.user_fk = purchases.user_fk GROUP BY ?, ?, ?)"
131131
}
132132
}

0 commit comments

Comments
 (0)