fix: support android #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashEngineering
commented
Apr 18, 2024
| @@ -127,7 +164,8 @@ fn main() { | |||
| cc.files(cpp_files) | |||
| .includes(&include_paths) | |||
| .cpp(true) | |||
| .flag_if_supported("-std=c++14"); | |||
| .flag_if_supported("-std=c++14") | |||
| .target(&env::var("TARGET").unwrap()); | |||
There was a problem hiding this comment.
the cc crate does support using the correct compiler based on the CC_* and AR_* environment variables, but it needs to know the target.
HashEngineering
commented
Apr 18, 2024
Comment on lines
+102
to
+105
| cmake_command | ||
| .arg(format!("-DANDROID_PLATFORM={}", android_abi)) | ||
| .arg(format!("-DANDROID_ABI={}", ndk_target)) | ||
| .arg(format!("-DCMAKE_TOOLCHAIN_FILE={}", cmake_toolchain_path)); |
There was a problem hiding this comment.
To support android, we need to specify the platform version (default will be 24, which is Android 7.0) and the ABI which will be one of the 4 specified by the root build process. Lastly, the toolchain is set to the Android toolchain.
This was referenced Apr 19, 2024
ogabrielides
dismissed stale reviews from UdjinM6, shumkov, and themself
The base branch was changed.
|
glad we have gh rules that protected from mistakes like that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make changes to build.rs to support android builds.