Fix broken tests on head due to Dart SDK update #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
changed the title
yieldControlToDDS
elliette
commented
Mar 25, 2024
| @@ -1548,6 +1548,11 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer. | |||
| return _rpcNotSupportedFuture('getVMTimelineMicros'); | |||
| } | |||
|
|
|||
| @override | |||
There was a problem hiding this comment.
#2388 has the actual implementation of this method, but I'm still working on getting all the tests passing on that PR.
elliette
commented
Mar 25, 2024
| await ws.close(); | ||
| }, | ||
| // TODO(elliette): Re-enable test. | ||
| skip: true, |
There was a problem hiding this comment.
This will be enabled and fixed with #2388
elliette
commented
Mar 25, 2024
| ); | ||
| }, | ||
| // TODO(elliette): Re-enable test. | ||
| skip: true, |
There was a problem hiding this comment.
This will be enabled and fixed in #2388
elliette
changed the title
bkonyi
reviewed
Mar 26, 2024
| }, | ||
| }; | ||
|
|
||
| // DDS should fail to start with existing vm clients. |
There was a problem hiding this comment.
DDS should only fail to start if there's an existing DDS instance. In the case of existing clients, the existing clients should be disconnected.
There was a problem hiding this comment.
Thanks! Will handle that in #2388, this change just skips the existing test
bkonyi
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The skipped tests will be re-enabled with #2388, but I'm still working on getting all the tests passing in that PR