Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate injected client to package:web #2338

Closed
annagrin opened this issue Jan 10, 2024 · 2 comments
Closed

Migrate injected client to package:web #2338

annagrin opened this issue Jan 10, 2024 · 2 comments
Assignees
@derekxu16
Labels
P2 A bug or feature request we're likely to work on package:dwds triaged

Comments

@annagrin
Copy link
Contributor

The currently used JS interop is restrictive and does not allow for passing structured data between the client and dwds.

Switch to the new package:web to allow for new features.
This was referenced Jan 10, 2024
Closed
Closed
@bkonyi bkonyi added package:dwds P2 A bug or feature request we're likely to work on triaged labels Aug 21, 2024
@bkonyi
Copy link
Collaborator

bkonyi commented Aug 21, 2024

It looks like most of the work for this is done (see #2306) but we need to investigate if there's going to be any breakages in google3.

@bkonyi
Copy link
Collaborator

bkonyi commented Aug 21, 2024 •
edited
Loading

We'll also want to follow up and migrate webdev as well (package:js_interop instead of package:js, dart:js, and dart:js_util and package:web instead of dart:html). See https://dart.dev/interop/js-interop#next-generation-js-interop.

This was referenced Oct 7, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekxu16 derekxu16

Labels
P2 A bug or feature request we're likely to work on package:dwds triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate injected client to package web annagrin/webdev
3 participants
@derekxu16 @annagrin @bkonyi