rev the sdk min to 2.19.0-0 (dart-archive/fixnum#99)

* rev the sdk min to 2.19.0-0 * remove localy use of ignore: unrelated_type_equality_checks * remove localy use of ignore: unrelated_type_equality_checks * Tweak constraint * Revert previous commit Co-authored-by: Michael Thomsen <[email protected]>
dart-lang · Dec 8, 2022 · e39009c · e39009c
1 parent 3fe3c3e
commit e39009c
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 8 deletions.
diff --git a/pkgs/fixnum/.github/workflows/test-package.yml b/pkgs/fixnum/.github/workflows/test-package.yml
@@ -47,7 +47,8 @@ jobs:
       matrix:
         # Add macos-latest and/or windows-latest if relevant for this package.
         os: [ubuntu-latest]
-        sdk: [2.12.0, dev]
+        # TODO(devoncarew): Add `2.19.0` to this once that release is stable
+        sdk: [dev]
     steps:
       - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
       - uses: dart-lang/setup-dart@6a218f2413a3e78e9087f638a238f6b40893203d

diff --git a/pkgs/fixnum/CHANGELOG.md b/pkgs/fixnum/CHANGELOG.md
@@ -1,11 +1,13 @@
-## 1.1.0
+## 1.1.0-dev
 
 * Add `tryParseRadix`, `tryParseInt` and `tryParseHex` static methods
   to both `Int32` and `Int64`.
 * Document exception and overflow behavior of parse functions,
   and of `toHexString`.
 * Make `Int32` parse functions consistent with documentation (accept
   leading minus sign, do not accept empty inputs).
+* Update the minimum SDK constraint to 2.19.
+
 ## 1.0.1
 
 * Switch to using `package:lints`.

diff --git a/pkgs/fixnum/pubspec.yaml b/pkgs/fixnum/pubspec.yaml
@@ -6,7 +6,7 @@ description: >-
 repository: https://github.com/dart-lang/fixnum
 
 environment:
-  sdk: '>=2.12.0 <3.0.0'
+  sdk: '>=2.19.0-0 <3.0.0'
 
 dev_dependencies:
   lints: ^1.0.0

diff --git a/pkgs/fixnum/test/int32_test.dart b/pkgs/fixnum/test/int32_test.dart
@@ -214,7 +214,7 @@ void main() {
       expect(Int32(17), isNot(equals(Int64(16))));
       expect(Int32.MIN_VALUE, isNot(equals(Int32.MAX_VALUE)));
       expect(Int32(17), isNot(equals(18)));
-      expect(Int32(17) == 17, isTrue); // ignore: unrelated_type_equality_checks
+      expect(Int32(17) == 17, isTrue);
       expect(Int32(17), isNot(equals(16)));
       expect(Int32(17), isNot(equals(Object())));
       expect(Int32(17), isNot(equals(null)));

diff --git a/pkgs/fixnum/test/int64_test.dart b/pkgs/fixnum/test/int64_test.dart
@@ -389,7 +389,7 @@ void main() {
       expect(Int64(0), isNot(equals(Int64(1))));
       expect(Int64(0), equals(Int32(0)));
       expect(Int64(0), isNot(equals(Int32(1))));
-      expect(Int64(0) == 0, isTrue); // ignore: unrelated_type_equality_checks
+      expect(Int64(0) == 0, isTrue);
       expect(Int64(0), isNot(equals(1)));
       expect(Int64(10), isNot(equals(Int64(11))));
       expect(Int64(10), equals(Int64(10)));
@@ -398,12 +398,11 @@ void main() {
       expect(Int64(10), equals(Int32(10)));
       expect(Int64(10), isNot(equals(Int32(9))));
       expect(Int64(10), isNot(equals(11)));
-      expect(Int64(10) == 10, isTrue); // ignore: unrelated_type_equality_checks
+      expect(Int64(10) == 10, isTrue);
       expect(Int64(10), isNot(equals(9)));
       expect(Int64(-10), equals(Int64(-10)));
       expect(Int64(-10) != Int64(-10), false);
-      expect(
-          Int64(-10) == -10, isTrue); // ignore: unrelated_type_equality_checks
+      expect(Int64(-10) == -10, isTrue);
       expect(Int64(-10), isNot(equals(-9)));
       expect(largePos, equals(largePos));
       expect(largePos, isNot(equals(largePosPlusOne)));