update the sdks we test against

dart-archive · devoncarew · Jan 30, 2023 · Jan 25, 2023 · Jan 25, 2023 · Jan 26, 2023
commit 9cd020a95210ab9725c6957f2bf965b06d85e64d
diff --git a/.github/workflows/test-package.yml b/.github/workflows/test-package.yml
@@ -20,7 +20,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        sdk: [dev, beta]
+        sdk: [2.19.0, dev]
     steps:
       - uses: actions/checkout@755da8c3cf115ac066823e79a1e1788f8940201b
       - uses: dart-lang/setup-dart@6a218f2413a3e78e9087f638a238f6b40893203d
@@ -47,8 +47,7 @@ jobs:
       matrix:
         # Add macos-latest and/or windows-latest if relevant for this package.
         os: [ubuntu-latest]
-        # TODO(devoncarew): Add `2.19.0` to this once that release is stable
-        sdk: [dev, beta]
+        sdk: [2.19.0, dev]
     steps:
       - uses: actions/checkout@755da8c3cf115ac066823e79a1e1788f8940201b
       - uses: dart-lang/setup-dart@6a218f2413a3e78e9087f638a238f6b40893203d

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@
 * Make `Int32` parse functions consistent with documentation (accept
   leading minus sign, do not accept empty inputs).
 * Update the minimum SDK constraint to 2.19.
+* Update to package:lints 2.0.0.
 
 ## 1.0.1
 

diff --git a/lib/src/utilities.dart b/lib/src/utilities.dart
@@ -16,12 +16,12 @@ int validateRadix(int radix) =>
 /// not a valid digit in any radix in the range 2 through 36.
 int decodeDigit(int c) {
   // Hex digit char codes
-  const int _c0 = 48; // '0'.codeUnitAt(0)
-  const int _ca = 97; // 'a'.codeUnitAt(0)
+  const int c0 = 48; // '0'.codeUnitAt(0)
+  const int ca = 97; // 'a'.codeUnitAt(0)
 
-  int digit = c ^ _c0;
+  int digit = c ^ c0;
   if (digit < 10) return digit;
-  int letter = (c | 0x20) - _ca;
+  int letter = (c | 0x20) - ca;
   if (letter >= 0) {
     // Returns values above 36 for invalid digits.
     // The value is checked against the actual radix where the return

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -9,5 +9,5 @@ environment:
   sdk: '>=2.19.0 <3.0.0'
 
 dev_dependencies:
-  lints: ^1.0.0
+  lints: ^2.0.0
   test: ^1.16.0
diff --git a/test/int64_test.dart b/test/int64_test.dart
@@ -714,16 +714,16 @@ void main() {
   });
 
   test('JavaScript 53-bit integer boundary', () {
-    Int64 _factorial(Int64 n) {
+    Int64 factorial(Int64 n) {
       if (n.isZero) {
         return Int64(1);
       } else {
-        return n * _factorial(n - Int64(1));
+        return n * factorial(n - Int64(1));
       }
     }
 
-    Int64 fact18 = _factorial(Int64(18));
-    Int64 fact17 = _factorial(Int64(17));
+    Int64 fact18 = factorial(Int64(18));
+    Int64 fact17 = factorial(Int64(17));
     expect(fact18 ~/ fact17, Int64(18));
   });