Fix parameter types for compareTo().

Also adding a CHANGELOG and analysis_options since it's strong mode clean now. [email protected], [email protected] Review URL: https://codereview.chromium.org//1963283002 .
dart-archive · May 10, 2016 · 2d95f7d · 2d95f7d
1 parent b212014
commit 2d95f7d
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 5 deletions.
diff --git a/.analysis_options b/.analysis_options
@@ -0,0 +1,2 @@
+analyzer:
+  strong-mode: true
diff --git a/.gitignore b/.gitignore
@@ -3,4 +3,5 @@
 .pub
 build
 packages
+.packages
 pubspec.lock
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -0,0 +1,5 @@
+## 0.10.5
+
+* Fix strong mode warning in overridden `compareTo()` methods.
+
+*No changelog entries for previous versions...*
diff --git a/lib/src/int32.dart b/lib/src/int32.dart
@@ -287,7 +287,7 @@ class Int32 implements IntX {
     return false;
   }
 
-  int compareTo(Comparable other) {
+  int compareTo(other) {
     if (other is Int64) {
       return this.toInt64().compareTo(other);
     }

diff --git a/lib/src/int64.dart b/lib/src/int64.dart
@@ -458,7 +458,7 @@ class Int64 implements IntX {
     return false;
   }
 
-  int compareTo(Comparable other) =>_compareTo(other);
+  int compareTo(other) => _compareTo(other);
 
   int _compareTo(other) {
     Int64 o = _promote(other);

diff --git a/lib/src/intx.dart b/lib/src/intx.dart
@@ -7,7 +7,7 @@ part of fixnum;
 /**
  * A fixed-precision integer.
  */
-abstract class IntX implements Comparable {
+abstract class IntX implements Comparable<dynamic> {
 
   /** Addition operator. */
   IntX operator +(other);
@@ -80,7 +80,7 @@ abstract class IntX implements Comparable {
    */
   IntX shiftRightUnsigned(int shiftAmount);
 
-  int compareTo(Comparable other);
+  int compareTo(other);
 
   /**
    * Returns `true` if and only if [other] is an int or IntX equal in

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: fixnum
-version: 0.10.4
+version: 0.10.5
 author: Dart Team <[email protected]>
 description: Library for 32- and 64-bit signed fixed-width integers.
 homepage: https://github.com/dart-lang/fixnum