Link image name in a Dockerfile (OctoLinker#142)

stefanbuck · josephfrazier · commit 33a2e60a5235 · 2016-08-02T19:23:02.000-04:00
diff --git a/lib/plugins/docker/index.js b/lib/plugins/docker/index.js
@@ -0,0 +1,16 @@
+import { DOCKER_FROM } from '../../../packages/helper-grammar-regex-collection/index.js';
+import insertLink from '../../insert-link';
+
+export default class Docker {
+
+  getPattern() {
+    return ['Dockerfile'];
+  }
+
+  parseBlob(blob) {
+    insertLink(blob.el, DOCKER_FROM, {
+      resolver: 'dockerImage',
+      image: '$1',
+    });
+  }
+}
diff --git a/lib/resolver/docker-image.js b/lib/resolver/docker-image.js
@@ -0,0 +1,12 @@
+export default function ({ image }) {
+  let isOffical = true;
+  const imageName = image.split(':')[0];
+
+  if (image.includes('/')) {
+    isOffical = false;
+  }
+
+  return [
+    `https://hub.docker.com/${isOffical ? '_' : 'r'}/${imageName}`,
+  ];
+}
diff --git a/lib/resolver/index.js b/lib/resolver/index.js
@@ -5,6 +5,7 @@ import gitUrl from './git-url.js';
 import githubShorthand from './github-shorthand.js';
 import javascriptUniversal from './javascript-universal.js';
 import rubyUniversal from './ruby-universal.js';
+import dockerImage from './docker-image.js';
 
 export {
   liveResolverQuery,
@@ -14,4 +15,5 @@ export {
   gitUrl,
   githubShorthand,
   rubyUniversal,
+  dockerImage,
 };
diff --git a/packages/helper-grammar-regex-collection/index.js b/packages/helper-grammar-regex-collection/index.js
@@ -9,6 +9,7 @@ const GEM = /gem (['"][^'"\s]+['"])/g;
 // we could just use https://github.com/Homebrew/homebrew-core/
 const HOMEBREW = /(?:depends_on|conflicts_with)(?: cask:)? (['"][^'"\s]+['"])/g;
 const TYPESCRIPT_REFERENCE = /\/{3}\s?<reference path=(['"][^'"\s]+['"])/g;
+const DOCKER_FROM = /FROM\s([^\n]*)/g;
 
 export {
   REQUIRE,
@@ -18,4 +19,5 @@ export {
   GEM,
   HOMEBREW,
   TYPESCRIPT_REFERENCE,
+  DOCKER_FROM,
 };
diff --git a/packages/helper-grammar-regex-collection/test.js b/packages/helper-grammar-regex-collection/test.js
@@ -126,6 +126,18 @@ const fixtures = {
       '// <reference path="foo" />',
     ],
   },
+  DOCKER_FROM: {
+    valid: [
+      ['FROM foo', ['foo']],
+      ['FROM foo:1.2.3', ['foo:1.2.3']],
+      ['FROM foo:1.2.3-alpha', ['foo:1.2.3-alpha']],
+      ['FROM foo/bar', ['foo/bar']],
+    ],
+    invalid: [
+      'FROMfoo',
+      // 'FROM\nfoo',
+    ],
+  },
 };
 
 describe('helper-grammar-regex-collection', () => {
diff --git a/test/resolver/docker-image.test.js b/test/resolver/docker-image.test.js
@@ -0,0 +1,39 @@
+import assert from 'assert';
+import dockerImage from '../../lib/resolver/docker-image.js';
+
+describe('docker-image', () => {
+  it('resolves foo to https://hub.docker.com/_/foo', () => {
+    assert.deepEqual(
+      dockerImage({ image: 'foo' }),
+      ['https://hub.docker.com/_/foo']
+    );
+  });
+
+  it('resolves foo:1.2.3 to https://hub.docker.com/_/foo', () => {
+    assert.deepEqual(
+      dockerImage({ image: 'foo:1.2.3' }),
+      ['https://hub.docker.com/_/foo']
+    );
+  });
+
+  it('resolves foo:1.2.3-alpha to https://hub.docker.com/_/foo', () => {
+    assert.deepEqual(
+      dockerImage({ image: 'foo:1.2.3-alpha' }),
+      ['https://hub.docker.com/_/foo']
+    );
+  });
+
+  it('resolves foo/bar to https://hub.docker.com/r/foo/bar', () => {
+    assert.deepEqual(
+      dockerImage({ image: 'foo/bar' }),
+      ['https://hub.docker.com/r/foo/bar']
+    );
+  });
+
+  it('resolves foo/bar:1.2.3 to https://hub.docker.com/r/foo/bar', () => {
+    assert.deepEqual(
+      dockerImage({ image: 'foo/bar:1.2.3' }),
+      ['https://hub.docker.com/r/foo/bar']
+    );
+  });
+});
