Skip to content

Edge example incorrectly published #498

Open
@MikeMcC399

Description

Issue

The published Edge Usage Example is incorrect and does not work:

version: '2.1'
orbs:
  cypress: cypress-io/cypress@3
jobs:
  edge-test:
    executor: cypress-browsers
    steps:
      - cypress/install
      - cypress/run-tests:
          cypress-command: npx cypress run --browser edge
          start-command: npm run start:dev
workflows:
  use-my-orb:
    jobs:
      - edge-test

It is missing the executors section

executors:
  cypress-browsers:
    docker:
      - image: cypress/browsers:node-20.17.0-chrome-129.0.6668.70-1-ff-130.0.1-edge-129.0.2792.52-1

Background

The example source code in src/examples/edge.yml is:

description: >
  Run Cypress tests in Microsoft Edge.
usage:
  version: 2.1
  orbs:
    cypress: cypress-io/cypress@3
  executors:
    cypress-browsers:
      docker:
        - image: cypress/browsers:node-20.17.0-chrome-129.0.6668.70-1-ff-130.0.1-edge-129.0.2792.52-1
  jobs:
    edge-test:
      executor: cypress-browsers
      steps:
        - cypress/install
        - cypress/run-tests:
            start-command: "npm run start:dev"
            cypress-command: 'npx cypress run --browser edge'
  workflows:
    use-my-orb:
      jobs:
        - edge-test

The runnable part of this code is

version: 2.1
orbs:
  cypress: cypress-io/cypress@3
executors:
  cypress-browsers:
    docker:
      - image: cypress/browsers:node-20.17.0-chrome-129.0.6668.70-1-ff-130.0.1-edge-129.0.2792.52-1
jobs:
  edge-test:
    executor: cypress-browsers
    steps:
      - cypress/install
      - cypress/run-tests:
          start-command: "npm run start:dev"
          cypress-command: 'npx cypress run --browser edge'
workflows:
  use-my-orb:
    jobs:
      - edge-test

However circleci orb pack ./src drops the executors section resulting in a non-working workflow.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions