-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Adding option to specify the package manager version that you want #486
base: master
Are you sure you want to change the base?
Conversation
|
313a196
to
9a25dc8
Compare
Could this also support using |
The question of Bun support is a complex topic. The immediate answer to your question would be NO.
|
e241bd6
to
352bca5
Compare
@jennifer-shehane I think this will also fix the failing pnpm test you mentioned here #485 (comment) but I created a specific PR just for that fix as well #492 |
Will you resolve the conflicts in this PR?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments and suggestions
Would you like to give some feedback about whether you want to continue with this PR? It looks like the pnpm process is working now without needing to specify the pnpm version (it's just using the latest version by default). |
Both pnpm and Yarn allow settting the package manager using
|
@MikeMcC399 Sorry, will look at fixing this during the week. Have had a busy few weeks. |
…to work as is not needed
1310415
to
41eb6a7
Compare
Thank you for updating the PR! For better readability, please mark the comments you consider as resolved using GitHub's Resolving conversations facility. There is a general problem with external PRs which needs feedback from the Cypress.io team described in: |
This will make it possible to install a specific version of a package manager through the cypress orb