Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adding option to specify the package manager version that you want #486

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ramykl
Copy link
Contributor

@ramykl ramykl commented Sep 12, 2024

This will make it possible to install a specific version of a package manager through the cypress orb

@cypress-app-bot
Copy link
Collaborator

@ramykl ramykl changed the title Adding option to specify the package manager version that you want Feat: Adding option to specify the package manager version that you want Sep 18, 2024
@MikeMcC399 MikeMcC399 added the type: enhancement New feature or request label Oct 2, 2024
@deiga
Copy link
Contributor

deiga commented Oct 7, 2024

Could this also support using bun https://bun.sh/?

@MikeMcC399
Copy link
Collaborator

@deiga

Could this also support using bun https://bun.sh/?

The question of Bun support is a complex topic. The immediate answer to your question would be NO.

  • Add support for Bun cypress#28962 would need to be addressed, and there would be other issues as well. If you want to open a separate issue on the topic of Bun support, we could try and list the gating factors there, as far as they affect the Cypress CircleCI Orb.

@ramykl ramykl force-pushed the rl/package-manager-version branch 2 times, most recently from e241bd6 to 352bca5 Compare November 4, 2024 14:24
@ramykl
Copy link
Contributor Author

ramykl commented Nov 4, 2024

@jennifer-shehane I think this will also fix the failing pnpm test you mentioned here #485 (comment) but I created a specific PR just for that fix as well #492

@MikeMcC399
Copy link
Collaborator

MikeMcC399 commented Nov 11, 2024

@ramykl

Will you resolve the conflicts in this PR?

Copy link
Collaborator

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments and suggestions

@MikeMcC399
Copy link
Collaborator

Would you like to give some feedback about whether you want to continue with this PR?

It looks like the pnpm process is working now without needing to specify the pnpm version (it's just using the latest version by default).

@MikeMcC399
Copy link
Collaborator

Both pnpm and Yarn allow settting the package manager using corepack in current versions, so there seems to be some overlap between selecting the package manager version through the Orb and selecting it through the project configuration.

@ramykl
Copy link
Contributor Author

ramykl commented Nov 18, 2024

@MikeMcC399 Sorry, will look at fixing this during the week. Have had a busy few weeks.

@MikeMcC399
Copy link
Collaborator

@ramykl

Thank you for updating the PR! For better readability, please mark the comments you consider as resolved using GitHub's Resolving conversations facility.

There is a general problem with external PRs which needs feedback from the Cypress.io team described in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants