-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semi-dense matching support (LoFTR) #173
Conversation
I've had some good results using this. I was wondering though, if there is a reason the matching is hard-coded to a batch size of 1? It occurs to me that more fully utilising the GPU & maybe allowing data-parallel across multiple GPUs might make working with this a lot faster / more practical. I'm also slightly confused about the use of |
Is this still in the pipeline to be merged? |
Yes this is still in the pipeline to be merged, and should be ready now. Tested on Aachen v1.1 with setup
Localization results:
Re batch size: I tested it and for me it only works with a batch size of 1 on Aachen (RTX 3080, 6 pairs / second). Nevertheless, I put the match extraction using LoFTR in a separate for-loop in case someone is willing to make this multi-GPU compatible. |
cc @JiamingSuen |
hloc/matchers/loftr.py
)hloc/match_dense.py
)