Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use old version of license_finder for old rubies #451

Merged
merged 1 commit into from
Jul 12, 2017

Conversation

maxmeyer
Copy link
Member

Summary

Downgrade license_finder to make the build succeed.

Motivation and Context

The gem uses the new "Safe Navigation Operator" which was introduced in
C-Ruby 2.3. This make the build fail: https://travis-ci.org/cucumber/aruba/jobs/252903532.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase withouth changing any existing functionality)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

The gem uses the new "Safe Navigation Operator" which was introduced in
C-Ruby 2.3. This make the build fail: https://travis-ci.org/cucumber/aruba/jobs/252903532.
@maxmeyer maxmeyer merged commit a604649 into master Jul 12, 2017
@maxmeyer maxmeyer added this to the 1.0.0-alpha.2 milestone Jul 13, 2017
@mvz mvz deleted the feature/use-old-version-of-license-finder branch November 7, 2017 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant