Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve developer experience #382

Merged
38 commits merged into from
Apr 28, 2016
Merged

Improve developer experience #382

38 commits merged into from
Apr 28, 2016

Conversation

maxmeyer
Copy link
Member

@maxmeyer maxmeyer commented Apr 28, 2016

Summary

This improves the dev experience and is based on @e2's work in #353.

Details

  • Run and build aruba in isolated environment via docker (credit @e2 in Use Docker for isolated testing #353)
  • Run container with docker-compose without making docker-compose a required dependency. Rake tasks read in the docker-compose.yml instead
  • Document developer rake tasks via cucumber features
  • Add more hints to CONTRIBUTING.md
  • Add TESTING.md (WIP) (credit @e2)
  • Cleanup rake tasks via separate namespaces
  • Some more minor fixes
  • Don't run feature test if executable required for test is not installed (python, bash, zsh, javac, ...)

Motivation and Context

How Has This Been Tested?

  • Covered by existing tests
  • Covered by newly added tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

maxmeyer added 30 commits April 17, 2016 12:08
This gives other developers the same experience than using the tools
directly
It's quite hard to review big chunks on github. If a developers splits
up her changes into multiple review is much easier for us maintainers.
This makes it also easier to cherry-pick changes.
This uses code from #353 (credit @e2) to improve code in bootstrap
script.
Otherwise rubocop will prevent going on.
@ghost ghost merged commit f56ef3d into master Apr 28, 2016
@ghost ghost mentioned this pull request Apr 28, 2016
5 tasks
@mvz mvz deleted the feature/imp-dev-xp-1 branch November 7, 2017 08:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant