Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly reset term colors (scripts) #352

Merged
merged 1 commit into from
Mar 30, 2016
Merged

Correctly reset term colors (scripts) #352

merged 1 commit into from
Mar 30, 2016

Conversation

e2
Copy link
Contributor

@e2 e2 commented Mar 30, 2016

On dark backgrounds, black was unreadable.
In most cases, e[39;39m should correctly reset the fg and bg colors.

@e2
Correctly reset term colors (scripts)
2af0f29 
On dark backgrounds, black was unreadable.
In most cases, e[39;39m should correctly reset the fg and bg colors.
@maxmeyer maxmeyer merged commit 81ec625 into cucumber:master Mar 30, 2016
@maxmeyer
Copy link
Member

Very good! Thanks.

@e2
Copy link
Contributor Author

e2 commented Mar 30, 2016

Should be: 39;49m in both cases. Oh well... still better than black.

@e2 e2 deleted the e2-fix_bootstrap_term_colors branch March 30, 2016 22:00
@maxmeyer
Copy link
Member

fixed. I like the new online editor of github. :-)

This was referenced Mar 15, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e2 @maxmeyer