Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add console support to aruba #305

Merged
4 commits merged into from Aug 11, 2015
Merged

Add console support to aruba #305

4 commits merged into from Aug 11, 2015

Conversation

ghost
Copy link

@ghost ghost commented Aug 11, 2015

This adds a console to aruba which users can use as "sandbox". It uses tmp/aruba as temporary directory.

ghost pushed a commit that referenced this pull request Aug 11, 2015
@ghost ghost merged commit c661554 into cucumber:master Aug 11, 2015
@ghost
Copy link
Author

ghost commented Aug 11, 2015

I merged this although there are some build failures. I could reproduce them with jruby 1.7.19. They are gone if you use jruby 1.7.20. On Travis we are forced to use 1.7.19.

@ghost
Copy link
Author

ghost commented Aug 11, 2015

@mattwynne Now we've got an aruba console 😄 Unfortunately we are bitten by some jruby bug(s). See comment above.

@mattwynne
Copy link
Member

mattwynne commented Aug 11, 2015 via email

@ghost
Copy link
Author

ghost commented Aug 11, 2015

Mmmh... Yes, I would like to do so, but is there something similar to skip_this_scenario in cucumber 1.3.x? #pending make the test suite fail as well.

@ghost
Copy link
Author

ghost commented Aug 11, 2015

#skip_this_scenario seems to be cucumber > 2 only.

@ghost
Copy link
Author

ghost commented Aug 11, 2015

And cucumber 2 requires ruby > 1.9.3. As we supported ruby 1.8.7, 1.9.2 by "chance" and made it official again using travis, we're stuck to cucumber 1.3.x at least for rubies < 1.9.3 till aruba >= 1.

@ghost
Copy link
Author

ghost commented Aug 11, 2015

BTW: I think, I'm going to prepare 0.9 to get some feedback on the structural changes I made. @aslakhellesoy This time with a proper announcement on cukes. Do you prefer to have a proper written announcement or is it ok to copy&paste the History.md-entry for the release? With the next iteration I would like to fix the Windows issues.

@ghost
Copy link
Author

ghost commented Aug 12, 2015

Ok. I added a hack to cucumber.yml to make it possible even for cucumber 1.3.x.

@ghost
Copy link
Author

ghost commented Aug 12, 2015

Ah... And what a about pre-releases. Should I announce them as well?

@mattwynne
Copy link
Member

@dg-ratiodata so many questions!

is there something similar to skip_this_scenario in cucumber 1.3.x? #pending make the test suite fail as well.

I would use tags and profiles to exclude the scenarios from the jruby build. That's what we do in Cucumber.

And cucumber 2 requires ruby > 1.9.3. As we supported ruby 1.8.7, 1.9.2 by "chance" and made it official again using travis, we're stuck to cucumber 1.3.x at least for rubies < 1.9.3 till aruba >= 1.

That sucks. I guess RSpec is the main driver for still supporting 1.8.7 yes? I think we maybe need to involve Myron in the conversation about dropping older Ruby version support. I'll ping him in cucumber/cucumber-ruby#902

Do you prefer to have a proper written announcement or is it ok to copy&paste the History.md-entry for the release?

History.md cut / paste is better than nothing, but a bit of narrative above it about the purpose of the release, and something about where you're headed next would be good for context.

I'd like you to write a blog post for http://cucumber.io/blog about Aruba and where you're headed with it. You can send blog posts as PRs adding files to this directory.

I think we need to formalise when we write a blog post and when we just post on cukes. I'm sloppy about this at the moment.

@ghost
Copy link
Author

ghost commented Aug 12, 2015

I would use tags and profiles to exclude the scenarios from the jruby build. That's what we do in Cucumber.

Yeah, found that out, too. 😄 https://github.com/cucumber/aruba/blob/master/cucumber.yml#L9

I guess RSpec is the main driver for still supporting 1.8.7 yes?

Yes, but they will stick to aruba 0.6.x for now. He had quite a few problems upgrading aruba to the latest version. Some problems were related to external bugs/problems by libraries used by aruba, but some were "home made" by aruba. See rspec/rspec-core#2028 for the discussion on this topic. It took too much of his free time.

I think we need to formalise when we write a blog post and when we just post on cukes. I'm sloppy about this at the moment.

That would be great. Plus some guidelines where those post should be published... I've got a blog on my own ;-) I use regularly - see https://www.fedux.org/articles.html

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants