Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make matcher have_permisions public and add documentation #239

Merged
merged 5 commits into from May 7, 2015
Merged

Make matcher have_permisions public and add documentation #239

merged 5 commits into from May 7, 2015

Conversation

ghost
Copy link

@ghost ghost commented Apr 28, 2015

I think the have_permissions-matchers is usable for other people as well. I think we should remove the @private-flag.

describe 'my feature' do
  it { expect('file.txt').to have_permissions(0700) }
end

I also added a configuration file for yardoc and the directory which is generated by yardoc during documentation generation is ignored now.

@mattwynne @jarl-dk Suggestions?

@ghost
Copy link
Author

ghost commented Apr 30, 2015

Rebased.

@mattwynne
Copy link
Member

LGTM

mattwynne added a commit that referenced this pull request May 7, 2015
@mattwynne
Merge pull request #239 from dg-ratiodata/feature/public_mode
3ddb7eb 
Make matcher have_permisions public and add documentation
@mattwynne mattwynne merged commit 3ddb7eb into cucumber:master May 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattwynne