Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/io stream #154

Merged
merged 14 commits into from
Jun 17, 2013
Merged

Feature/io stream #154

merged 14 commits into from
Jun 17, 2013

Conversation

maxmeyer
Copy link
Member

PR for Issue #153

@maxmeyer maxmeyer closed this May 26, 2013
@maxmeyer maxmeyer reopened this May 26, 2013
@maxmeyer maxmeyer mentioned this pull request May 26, 2013
@jarl-dk
Copy link
Member

jarl-dk commented Jun 7, 2013

Thank you for your interest, please refactor as advised.

Maybe the API#eot method could have a better name ? maybe #close_input, @mattwynne: What do you think?

@maxmeyer
Copy link
Member Author

maxmeyer commented Jun 9, 2013

better? i also added fuubar to development deps. otherwise rspec complains about a missing lib.

@maxmeyer
Copy link
Member Author

maxmeyer commented Jun 9, 2013

arg. the travis build failed. will get into this later

jarl-dk added a commit that referenced this pull request Jun 17, 2013
@jarl-dk jarl-dk merged commit 1203ff2 into cucumber:master Jun 17, 2013
@jarl-dk
Copy link
Member

jarl-dk commented Jun 17, 2013

@maxmeyer: Thanks for your contribution. I think actually that #close_input is a much better name, there is a bonus if you some how rename the #eot method to #close_input and make #eot work but mark it deprecated with some kind of warning.

@maxmeyer
Copy link
Member Author

Bonus? Great ;-) I will send you another PR.

@maxmeyer maxmeyer deleted the feature/io_stream branch June 19, 2013 06:03
@maxmeyer maxmeyer mentioned this pull request Jun 19, 2013
@maxmeyer
Copy link
Member Author

see #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants