Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore multiple files/directories #1692

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Restore multiple files/directories #1692

merged 4 commits into from
Dec 12, 2024

Conversation

Chouhartem
Copy link
Contributor

@Chouhartem Chouhartem commented Oct 22, 2024

This QoL PR implements the restoration of several files/directories from Trash as per #1651.

The multiple selection from Trash is bugged as of 2024.9.0, but #1681 fixes it.

  • Notes:
    • It adds a translation key for the restoration of multiple files (plural form);
    • It calls the interface refresh() functions as many times as there are files to be restored, it may cause performance issues when restoring too many files.
      • Fixed

@Chouhartem Chouhartem added Feature Request Something you want that isn't implemented Drive Anything related to CryptPad interface, not apps UI/UX Interfaces & user experience labels Oct 22, 2024
@Chouhartem Chouhartem added this to the Winter release (2024.12.0) milestone Oct 22, 2024
@Chouhartem Chouhartem changed the base branch from main to staging October 22, 2024 13:43
@Chouhartem Chouhartem added the Ready to Review This PR is ready to be checked by another team member label Oct 22, 2024
@Chouhartem Chouhartem linked an issue Oct 22, 2024 that may be closed by this pull request
- Add a non-zero timeout to avoid flooding the browser
- Fix an issue in #1692
@yflory yflory added Ready to Test This PR is ready to be tested and removed Ready to Review This PR is ready to be checked by another team member labels Dec 3, 2024
@yflory yflory merged commit 5afad5b into staging Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drive Anything related to CryptPad interface, not apps Feature Request Something you want that isn't implemented Ready to Test This PR is ready to be tested UI/UX Interfaces & user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restoring multiple elements from Trash
2 participants