Notification fixes #1674
Merged
Notification fixes #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariiing
added
Accessibility
|
This accessibility issue touches another potential problem in all notifications that have a user avatar as their icon. In all those cases clicking the avatar in the notification takes you to the user's profile while clicking on the notification body takes you to the relevant document, contact request, or other |
dariiing
removed
the
Ready to Review
|
The fix implemented for #1525 changes the hover style for any notification that contains the avatar icon. |
|
Fix for #1524: Untitled.video.-.Made.with.Clipchamp.mp4 |
dariiing
added
the
Ready to Review
dariiing
removed
the
Ready to Review
remove `:has` selector
dariiing
added
the
Ready to Review
yflory
requested changes
Dec 5, 2024
| background-color: @cp_dropdown-bg-hover; | ||
| } | ||
| } | ||
| li[role="menuitem"].cp-notification-avatar { |
There was a problem hiding this comment.
dropdown.less is a generic file containing style for all dropdown in CryptPad. You shouldn't put style specific to the notifications here. notifications.less is more appropriate for these changes.
yflory
approved these changes
Dec 10, 2024
yflory
added
Ready to Test
…pad/cryptpad into contact-request-notification-fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR addresses two issues related to some specific notifications: