-
-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): interface updates #1477
base: main
Are you sure you want to change the base?
Conversation
i'm hoping to get some feedback early on, so i don't spend too much time on it if this isn't of interest to the team and/or if i'm going in the wrong direction with what i'd like to achieve |
Hello, I'll let our designer, answer you more in-depth. However, I can already inform you that we moved away from sharp corners to rounded ones in 5.0.0. Looking at your screenshot of the drive, it looks like you will be reverting those changes. |
Hi @xyhhx thanks for your interest and for starting work on this new look. As the project lead and only designer on the team I see where you are coming from but I also think we are unlikely to move in this direction for the following reasons:
|
@davidbenque thanks for the feedback. sorry for the novella but i've got some counterpoints 😅 :
so, all this to say that i would really like to help cryptpad with your design elements. i want to see cryptpad thrive, it's a fascinating product, and i think it'd be invaluable in the hands of many groups. i'll probably keep working in the direction i have thus far and keep it a soft-fork for now, and that on its own will help me assimilate with the codebase somewhat as for contributing acceptable changes, i think it'd be massively helpful if you could share with me some sites/apps from who you draw inspiration, design and accessibility wise, and maybe i'll try to come up with a penpot project to showcase ideas before working on them. i'm in your matrix rooms, and you can reach me any time at @xyhhx:matrix.org thanks again, and i hope i didn't come off as too harsh at any point |
Hi, Thanks for being interested in helping out. Any help is definitively welcome as we do needs more opinions and also help to make improvements. I see some of the discussion has been around rounded corners, but maybe there is more to your proposals than just rounded corners. In your screenshot, I have to say, on my side I kind of like that the folder tree has a white background compared to the current grey one. I noticed that much more than the change on rounded corners. Concerning the onlyoffice coherency, as David said there are many other editors (wysiwyg, code, kanban, diagram). I would say that if we can we could also try to tweak the onlyoffice UI to get more into our own UI. But we do need to be careful as this could end up creating problems or be a lot of work. Maybe the part that we could improve is really the button bar.. I think the grey background in general is something that we could consider as not so nice. If I compare it with a Nextcloud bar (not exactly the same though), it uses slight different colors for the background of the menu items. We've made quite some progress in the 5.0 cycle to improve different areas and clean the UI. There are probably still some places (such as the sidebars where we can make improvements) |
@ldubost thanks for the response! my screenshot was only after one commit, and rounded/sharp corners are actually literally only one line change 😅 the majority of my changes went towards stuff like: cleaning up padding and margins; removing needless backgrounds and box-shadows that cluttered the interface; swapping open sans for inter which is far more legible and versatile; and improving contrast in some areas. other things that bug me while using the app are inconsistencies (two that come to mind are the difference in font size between folder and file headers in drive list view, and the difference in font size for filenames between drive and teams drive)
these are all cryptpad apps, are they not? i was planning on going over all of those too, to ensure everything was coherent. that said, i don't think that change onlyoffice's design is a realistic option, either; and even if it was i think it'd be bad ux since most onlyoffice users like it since it's a small change compared to microsoft office. all that being said, i do not care strongly whether round or sharp corners are used in particular. here was my thought process on the matter:
so, that left me with microsoft's offerings of windows and office 365, which made even more sense considering onlyoffice. still, i didn't want to strictly overhaul the ux, but simply clean the ui up to be more what a user of those softwares would expect of it. here, i'll attach more screenshots of some of the other changes so you can get a better idea, but you might be better off just checking out my repo and trying it out yourself: |
this PR proposes changes to the interface to more closely align with conventional file browsers, cloud drives, and the onlyoffice interface.
i'm drawing inspiration from windows file explorer, GNOME's nautilus (with adwaita), microsoft onedrive, and of course onlyoffice.
some images i am referring to while working on this
(not complete i gotta go find all the screenshots i was looking at last night)
i also find this article which has some nice looking screenshots i might take some inspo from too
goals and QA run through: