Fixed some indexes to align correctly with testing conventions

urabhay10 · urabhay10 · commit a9771ef92fe3 · 2024-10-21T12:14:53.000+05:30
diff --git a/src/data_structures/fenwick.md b/src/data_structures/fenwick.md
@@ -127,12 +127,12 @@ struct FenwickTree {
 
     FenwickTree(vector<int> const &a) : FenwickTree(a.size()) {
         for (size_t i = 1; i <= a.size(); i++)
-            add(i, a[i-1]);
+            add(i-1, a[i-1]);
     }
 
     int sum(int r) {
         int ret = 0;
-        for (; r > 0; r -= (r & -r))
+        for (++r; r > 0; r -= (r & -r))
             ret += bit[r];
         return ret;
     }
@@ -142,7 +142,7 @@ struct FenwickTree {
     }
 
     void add(int idx, int delta) {
-        for (; idx <= n; idx += (idx & -idx))
+        for (++idx; idx <= n; idx += (idx & -idx))
             bit[idx] += delta;
     }
 };
@@ -185,18 +185,18 @@ struct FenwickTreeMin {
 
     FenwickTreeMin(vector<int> a) : FenwickTreeMin(a.size()) {
         for (size_t i = 1; i <= a.size(); i++)
-            update(i, a[i-1]);
+            update(i-1, a[i-1]);
     }
 
     int getmin(int r) {
         int ret = INF;
-        for (; r > 0; r -= (r & -r))
+        for (++r; r > 0; r -= (r & -r))
             ret = min(ret, bit[r]);
         return ret;
     }
 
     void update(int idx, int val) {
-        for (; idx <= n; idx += (idx & -idx))
+        for (++idx; idx <= n; idx += (idx & -idx))
             bit[idx] = min(bit[idx], val);
     }
 };

Original file line number	Diff line number	Diff line change
`@@ -127,12 +127,12 @@ struct FenwickTree {`
`127`	`127`
`128`	`128`	`FenwickTree(vector<int> const &a) : FenwickTree(a.size()) {`
`129`	`129`	`for (size_t i = 1; i <= a.size(); i++)`
`130`		`- add(i, a[i-1]);`
	`130`	`+ add(i-1, a[i-1]);`
`131`	`131`	`}`
`132`	`132`
`133`	`133`	`int sum(int r) {`
`134`	`134`	`int ret = 0;`
`135`		`- for (; r > 0; r -= (r & -r))`
	`135`	`+ for (++r; r > 0; r -= (r & -r))`
`136`	`136`	`ret += bit[r];`
`137`	`137`	`return ret;`
`138`	`138`	`}`
`@@ -142,7 +142,7 @@ struct FenwickTree {`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	`void add(int idx, int delta) {`
`145`		`- for (; idx <= n; idx += (idx & -idx))`
	`145`	`+ for (++idx; idx <= n; idx += (idx & -idx))`
`146`	`146`	`bit[idx] += delta;`
`147`	`147`	`}`
`148`	`148`	`};`
`@@ -185,18 +185,18 @@ struct FenwickTreeMin {`
`185`	`185`
`186`	`186`	`FenwickTreeMin(vector<int> a) : FenwickTreeMin(a.size()) {`
`187`	`187`	`for (size_t i = 1; i <= a.size(); i++)`
`188`		`- update(i, a[i-1]);`
	`188`	`+ update(i-1, a[i-1]);`
`189`	`189`	`}`
`190`	`190`
`191`	`191`	`int getmin(int r) {`
`192`	`192`	`int ret = INF;`
`193`		`- for (; r > 0; r -= (r & -r))`
	`193`	`+ for (++r; r > 0; r -= (r & -r))`
`194`	`194`	`ret = min(ret, bit[r]);`
`195`	`195`	`return ret;`
`196`	`196`	`}`
`197`	`197`
`198`	`198`	`void update(int idx, int val) {`
`199`		`- for (; idx <= n; idx += (idx & -idx))`
	`199`	`+ for (++idx; idx <= n; idx += (idx & -idx))`
`200`	`200`	`bit[idx] = min(bit[idx], val);`
`201`	`201`	`}`
`202`	`202`	`};`