Skip to content

Commit a3aee38

Browse files
committed
build: better way to default versions in action matrix
These were flagged (incorrectly imo) by `actionlint`, but this is more readable anyway.
1 parent 99cb3c7 commit a3aee38

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

.github/workflows/coverage.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
6363
coverage:
6464
name: "${{ matrix.python-version }} on ${{ matrix.os }}"
65-
runs-on: "${{ matrix.os }}-${{ matrix.os-version || 'latest' }}"
65+
runs-on: "${{ matrix.os }}-${{ matrix.os-version }}"
6666
timeout-minutes: 10
6767

6868
# Only run coverage if Python files or this workflow changed.
@@ -80,6 +80,8 @@ jobs:
8080
- ubuntu
8181
- macos
8282
- windows
83+
os-version:
84+
- latest
8385
python-version:
8486
# When changing this list, be sure to check the [gh] list in
8587
# tox.ini so that tox will run properly. PYVERSIONS

.github/workflows/kit.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@ jobs:
5353
MATRIX_ID: "${{ matrix.py }}-${{ matrix.os }}-${{ matrix.arch }}"
5454
strategy:
5555
matrix:
56+
minpy:
57+
- "3.11" # PYVERSIONS needed by cibuildwheel
5658
include:
5759
# To change the matrix, edit the choices, then process this file with cog:
5860
#
@@ -173,7 +175,7 @@ jobs:
173175
- name: "Install Python"
174176
uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0
175177
with:
176-
python-version: "${{ matrix.minpy || '3.11' }}" # PYVERSIONS needed by cibuildwheel
178+
python-version: "${{ matrix.minpy }}"
177179
cache: pip
178180
cache-dependency-path: 'requirements/*.pip'
179181

.github/workflows/testsuite.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ jobs:
5959
6060
tests:
6161
name: "${{ matrix.python-version }} on ${{ matrix.os }}"
62-
runs-on: "${{ matrix.os }}-${{ matrix.os-version || 'latest' }}"
62+
runs-on: "${{ matrix.os }}-${{ matrix.os-version }}"
6363
timeout-minutes: 10
6464

6565
# Don't run tests if the branch name includes "-notests".
@@ -78,6 +78,8 @@ jobs:
7878
- ubuntu
7979
- macos
8080
- windows
81+
os-version:
82+
- latest
8183
python-version:
8284
# When changing this list, be sure to check the [gh] list in
8385
# tox.ini so that tox will run properly. PYVERSIONS

0 commit comments

Comments
 (0)