deprecate plugin/proxy #1443
Comments
|
For Infoblox use case, I need a proxy/forward with:
|
|
yeah, forward must/should support grpc. and health.Healther is sensible for all plugins. Not 100% sold on the need to specify client side policy. |
|
👍 from our side, but we don't need grpc, policies other than random or HTTP checks. My opinion on "battle hardened" differs as well ;-) |
|
"seen more production use" might be a better description. |
|
Also: if you query proxy and the upstream of proxy timeout, this is attributed to the proxy, forward avoids this mistake. |
|
We have been used proxy plugin to allow to use with external service via gRPC in production. But It seems that proxy plugin is already deptecated (#2651). This causes the block of update of CoreDNS in our environment. Are there specific plans to support gRPC in the forward plugin? |
|
Is trivial to add external plugins to coredns, so I don't see any problems
here.
(Do need to double check if coredns/proxy compiles).
As to gRPC proxy functionality, I think this should be done as a new plugin.
…On Tue, 5 Mar 2019, 00:55 Moto Ishizawa, ***@***.***> wrote:
We have been used proxy plugin to allow to use with external service via
gRPC in production. But It seems that proxy plugin is already deptecated (
#2651 <#2651>).
This causes the block of update of CoreDNS in our environment. Are there
specific plans to support gRPC in the forward plugin?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1443 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVkW5bM1twzmabUm32aSlKKDm-aaTDeks5vTcCAgaJpZM4Ruk1a>
.
|
|
@miekg It's worth pointing out that |
|
[ Quoting <[email protected]> in "Re: [coredns/coredns] deprecate plu..." ]
@miekg It's worth pointing out that `forward` does not support `dnstap` logging of forwarded queries/responses, so deprecating `proxy` effectively cripples the usefulness of the `dnstap` plugin if we don't add the functionality to `forward`.
yep, and there is an issue open for that.
As previous said, including proxy is easy. It's removed because healthchecking
is not good, it's not fast enough and too complex
|
|
Found it #1448 - thank you! |
|
closing here, as its' gone. Cleaning up the last bit and then really make it external. |
Correct the `Corefile` use of `proxy` with `forward`. Proxy directive was deprecated here: coredns/coredns#1443
I want to deprecate proxy in favor of forward.
Why:
We have had a long discussion on Slack about an outage that is attributed to the proxy code (spec. the healthchecking (HC)). This took 2 engineers quite a while to reason about the current code; it is complex. I think it is gotten too complex.
forward uses inband HC (by default), and just traverses a list, so no
Select()what proxy currently does. And the code in forward is simpler. It also caches udp and tcp sockets, so it is faster.Why not:
Proposal:
The text was updated successfully, but these errors were encountered: