Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copts.defaultRuntime to NewWithConn() when it is specify the ops. #9703

Closed
wants to merge 1 commit into from
Closed

Add copts.defaultRuntime to NewWithConn() when it is specify the ops. #9703

wants to merge 1 commit into from

Conversation

yanggangtony
Copy link
Contributor

@yanggangtony yanggangtony commented Jan 29, 2024 •
edited
Loading

/kind cleanup
/kind bug

We should not omit the copts.defaultRuntime when it is actually passd in from the Outer of Method func NewWithConn(

Demo code:

import (
	containerd "github.com/containerd/containerd/v2/client"
) 
func main(){
xxx

containerd.NewWithConn(xxx)

xxx
}

If before conn has set the runtime , when use the containerd.NewWithConn() , will drop the before runtime set , and use default set .

@k8s-ci-robot
Copy link

Hi @yanggangtony. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yanggangtony yanggangtony force-pushed the add-client-new-func-defaultRuntime branch from 5a64a0b to 889b356 Compare January 29, 2024 09:12
@yanggangtony
Copy link
Contributor Author

Hey, friendly ping .
This pr is for a long time .
Would someone put it for progress?

@yanggangtony yanggangtony deleted the add-client-new-func-defaultRuntime branch March 11, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanggangtony @k8s-ci-robot