Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React v19 support #476

Closed
rinarakaki opened this issue Nov 3, 2024 · 6 comments · Fixed by #495
Closed

React v19 support #476

rinarakaki opened this issue Nov 3, 2024 · 6 comments · Fixed by #495

Comments

@rinarakaki
Copy link

rinarakaki commented Nov 3, 2024

Would we include react v19rc support in the upcoming v2? #475

@paul-sachs
Copy link
Collaborator

paul-sachs commented Nov 4, 2024

We haven't tested the library with react 19, though it probably won't have any problems assuming react-query doesn't have any react 19 issues. @rinarakaki have you noticed any specific issues when using react 19 and the 2.0 rc releases?

@rinarakaki
Copy link
Author

I haven't had any problems so far. Also better to try the latest rc.3 so could you please resolve #481?

@corentinmusard
Copy link

corentinmusard commented Nov 25, 2024

Hey, can you elaborate on how is this issue completed?

I still see that connect-query doesn't have support for React 19 in package.json.

"react": "^18.3.1",
"react-dom": "^18.3.1",

@timostamm
Copy link
Member

Let's reopen this as "React v19 support".

I think it's possible to relax the peer dependency constraint to include the v19 rc to make it easier for users to try out.

I'm not sure TanStack Query works well with the new use though, see this blog post for context. React 19 is still a release candidate, and it's possible that there will be another one with breaking changes.

@timostamm timostamm reopened this Nov 25, 2024
@timostamm timostamm changed the title React v19 rc support React v19 support Nov 25, 2024
@paul-sachs
Copy link
Collaborator

paul-sachs commented Dec 13, 2024

Fixed and released in 2.0.1

@rinarakaki
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants