Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add T.source as an alternative to T.sources but for single files #546

Closed
lefou opened this issue Feb 14, 2019 · 3 comments
Closed

Add T.source as an alternative to T.sources but for single files #546

lefou opened this issue Feb 14, 2019 · 3 comments
Milestone
0.5.7

Comments

@lefou
Copy link
Member

lefou commented Feb 14, 2019

Using T.sources in case where only a single file is expected, leads to unnecessary error sources.
lihaoyi added a commit that referenced this issue Dec 24, 2019
@lihaoyi
add T.source to listen to a single source file/folder
e461c50 
#546
@lihaoyi lihaoyi mentioned this issue Dec 24, 2019
Merged
@lefou
Copy link
Member Author

lefou commented Dec 24, 2019

I'm asking myself, if the already present T.input[PathRef] is enough.

According to documentation and my personal experience, T.input[Seq[PathRef]] and T.sources should behave identical, except the more specialized type.

@lefou
Copy link
Member Author

lefou commented Dec 24, 2019 •
edited
Loading

So, instead of a new def myFile = T.source(theFile) we might just write def myFile = T.input { PathRef(theFile) }

lihaoyi added a commit that referenced this issue Dec 24, 2019
@lihaoyi
Add T.source to listen to a single source file/folder (#749)
17805a9 
Add T.source to listen to a single source file/folder

#546

Largely copy-pasted from T.sources, with all the Seq-related stuff removed

Not super heavily tested, but I stuffed a single usage into JavacCompileJavaTests to make sure it at least gets some coverage. Seems to work.

Review by @lefou
@lihaoyi
Copy link
Member

lihaoyi commented Dec 24, 2019

#749

@lihaoyi lihaoyi closed this as completed Dec 24, 2019
@lefou lefou added this to the after 0.5.6 milestone Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.7
Development

No branches or pull requests
2 participants
@lihaoyi @lefou