Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: com-lihaoyi/mill
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.11.3
Choose a base ref
...
head repository: com-lihaoyi/mill
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.11.4
Choose a head ref
  • 10 commits
  • 9 files changed
  • 5 contributors

Commits on Sep 17, 2023

  1. Configuration menu
    Copy the full SHA
    9b075ae View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Configuration menu
    Copy the full SHA
    b88db7d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    62cae94 View commit details
    Browse the repository at this point in the history
  3. Some post-release tasks (#2745)

    Pull request: #2745
    lefou authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    b074ac9 View commit details
    Browse the repository at this point in the history
  4. Update mill-mima to 0.0.24 (#2746)

    Pull request: #2746
    lefou authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    9d0d68c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e5bd30b View commit details
    Browse the repository at this point in the history
  6. Update htmlcleaner to 2.29 (#2747)

    Pull request: #2747
    lefou authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    95c68ca View commit details
    Browse the repository at this point in the history
  7. Support release-size releaseMode in Scala Native (#2754)

    Co-authored-by: Tobias Roeser <[email protected]>
    
    Pull request: #2754
    lolgab authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    55d04b4 View commit details
    Browse the repository at this point in the history
  8. Fix sneaky binary incompatibility in Discover.scala (#2752)

    fixes #2749
    
    The basic problem is that the signature of `Discover.apply()` changed,
    but it only changed in the argument's generic type parameters, so it was
    nominally the same type after erasure, and accepted the `Map[Class[_],
    Seq]` even though it was expecting a `Map[Class[_], (Seq, Seq)]`, but
    later on in the code it would blow up with a `ClassCastException`
    
    This causes problems with Mill plugins containing external modules,
    which have their own `Discover[T]` macro pre-expanded and would not get
    re-compiled with the new 0.11.3 version of Mill.
    
    This PR works around the problem by adding a forwarder
    `Discover.apply(value: Map[Class, Seq])` that does the right thing and
    expands the `Seq` into a `(Seq, Seq)`, while adding a dummy paramter to
    `case class Discover` to avoid conflicts. A similar forwarder
    `Discover.<init>(value: Map[Class, Seq])` is needed to preserve binary
    compatibility (I think?)
    
    Tested manually via `./mill -i dev.run example/basic/1-simple-scala
    --import ivy:io.chris-kipp::mill-github-dependency-graph::0.2.6
    io.kipp.mill.github.dependency.graph.Graph/generate`, which fails before
    this PR and passes after
    
    ---------
    
    Co-authored-by: Chris Kipp <[email protected]>
    Co-authored-by: Tobias Roeser <[email protected]>
    3 people authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    98bbfe8 View commit details
    Browse the repository at this point in the history
  9. 0.11.4

    lihaoyi committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    ee9b8ef View commit details
    Browse the repository at this point in the history
Loading