Improve error reporting in the "try_run" function and correctly include original command output in the error message (#153)

Kami · thomasrockhu · web-flow · commit 663888151217 · 2020-09-09T16:58:13.000-04:00
* Log more info when a command fails.

* Also log return code.

* Correctly include process output with the thrown exception.

* Include returncode before the output.

* Update codecov/__init__.py

* black

Co-authored-by: Thomas Hu &lt;thomasrockhu@users.noreply.github.com&gt;
Co-authored-by: Thomas Hu &lt;tomhu1096@gmail.com&gt;
diff --git a/codecov/__init__.py b/codecov/__init__.py
@@ -213,7 +213,7 @@ def check_output(cmd, **popen_args):
     process = Popen(cmd, stdout=PIPE, **popen_args)
     output, _ = process.communicate()
     if process.returncode:
-        raise CalledProcessError(process.returncode, cmd)
+        raise CalledProcessError(process.returncode, cmd, output)
     else:
         assert process.returncode == 0
         return output.decode("utf-8")
@@ -223,7 +223,10 @@ def try_to_run(cmd, shell=False, cwd=None):
     try:
         return check_output(cmd, shell=shell, cwd=cwd)
     except Exception as e:
-        write("    Error running `%s`: %s" % (cmd, e or str(e)))
+        write(
+            "    Error running `%s`: returncode=%s, output=%s"
+            % (cmd, e.returncode, str(getattr(e, "output", str(e))))
+        )
         return None
 
 
