Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): improve logger description #362

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

L2ncE
Copy link
Member

@L2ncE L2ncE commented Nov 10, 2022

What type of PR is this?

docs

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

优化对 README 中 logger 的描述

Which issue(s) this PR fixes:

None.

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 66.53% // Head: 66.54% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (5054dab) compared to base (3f8c34e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #362      +/-   ##
===========================================
+ Coverage    66.53%   66.54%   +0.01%     
===========================================
  Files           89       89              
  Lines         8495     8507      +12     
===========================================
+ Hits          5652     5661       +9     
- Misses        2482     2484       +2     
- Partials       361      362       +1     
Impacted Files Coverage Δ
pkg/common/timer/timer.go 61.90% <0.00%> (-19.05%) ⬇️
pkg/app/server/option.go 96.63% <0.00%> (ø)
pkg/common/config/option.go 100.00% <0.00%> (ø)
pkg/route/engine.go 62.63% <0.00%> (+0.57%) ⬆️
pkg/common/compress/compress.go 83.80% <0.00%> (+2.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@welkeyever welkeyever merged commit 0688b6c into cloudwego:develop Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants