Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: Add possibility to configure custom pg_hba #321

Merged
merged 10 commits into from
Sep 4, 2024

Conversation

mjtrangoni
Copy link
Contributor

Hi,

This is a BREAKING CHANGE, and fixes #308.

IMHO, we should go with this kind of fixes now and taking into account that postgresql has a lot of configurations defined here, not only parameters, this fixes the way it will be handled.

Thank you!

PS: I had to remove one trailing space for the the CI to success, but in a separate commit so that you can remove it easily

@mjtrangoni mjtrangoni requested a review from itay-grudev as a code owner June 18, 2024 15:17
@itay-grudev
Copy link
Collaborator

I agree with this change. The advantage of running with version < 0.x,x is that breaking changes can happen while evaluating the initial prototype in the wild.

I will release it as 0.1.0 and add the relevant changelog entry.

@itay-grudev
Copy link
Collaborator

itay-grudev commented Jun 19, 2024

@mjtrangoni Could you please run make schema? It's why the tests are failing, I think.

@mjtrangoni
Copy link
Contributor Author

Hi @itay-grudev,

Thanks for your prompt reply. It seems I can't run it on my end, because the schema-gen does not support darwin, and is also not maintained anymore. Any hints on how to override this?

See,

$make schema
Error: unknown command "schema-gen" for "helm"
Run 'helm --help' for usage.
Error: unknown command "schema-gen" for "helm"
Run 'helm --help' for usage.
$ helm plugin install https://github.com/karuppiah7890/helm-schema-gen.git
karuppiah7890/helm-schema-gen crit platform darwin/arm64 is not supported.  Make sure this script is up-to-date and file request at https://github.com/karuppiah7890/helm-schema-gen/issues/new
Error: plugin install hook for "schema-gen" exited with error

Signed-off-by: Itay Grudev <[email protected]>
@mjtrangoni
Copy link
Contributor Author

mjtrangoni commented Jun 19, 2024

@itay-grudev tests are green now. pg_hba should be an array and not an object.

@mjtrangoni mjtrangoni force-pushed the add-cluster-pg-hba branch from 31686e6 to 171d53c Compare June 19, 2024 11:54
@itay-grudev
Copy link
Collaborator

I was just going through the documentation and found, that we've documented the postgresql: as a proxy to the full configuration.

So this means that this is no longer a simply a braking change, but also a bug fix.

@mjtrangoni
Copy link
Contributor Author

@itay-grudev is there any release date for this?

@itay-grudev
Copy link
Collaborator

@mjtrangoni I apologise about the delay. I wanted to merge some other work first and then this, as this would require a minor patch due to breaking changes. If I get everything reviewed next week, I'll merge it.

@itay-grudev
Copy link
Collaborator

P.S. The moment I update this branch in a moment, the test should fail due to the test suite that I just added to the chart. The test will need to be updated, but I'll take care of that. I have edit access to your branch.

@itay-grudev itay-grudev added the chart( cluster ) Related to the cluster chart label Aug 9, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes chart( cluster ) Related to the cluster chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting up pg_hba not working
2 participants