-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: Add possibility to configure custom pg_hba #321
cluster: Add possibility to configure custom pg_hba #321
Conversation
Signed-off-by: Mario Trangoni <[email protected]>
Signed-off-by: Mario Trangoni <[email protected]>
I agree with this change. The advantage of running with version I will release it as |
@mjtrangoni Could you please run |
Hi @itay-grudev, Thanks for your prompt reply. It seems I can't run it on my end, because the schema-gen does not support darwin, and is also not maintained anymore. Any hints on how to override this? See, $make schema
Error: unknown command "schema-gen" for "helm"
Run 'helm --help' for usage.
Error: unknown command "schema-gen" for "helm"
Run 'helm --help' for usage.
$ helm plugin install https://github.com/karuppiah7890/helm-schema-gen.git
karuppiah7890/helm-schema-gen crit platform darwin/arm64 is not supported. Make sure this script is up-to-date and file request at https://github.com/karuppiah7890/helm-schema-gen/issues/new
Error: plugin install hook for "schema-gen" exited with error |
Signed-off-by: Itay Grudev <[email protected]>
@itay-grudev tests are green now. pg_hba should be an array and not an object. |
…ject Signed-off-by: Mario Trangoni <[email protected]>
31686e6
to
171d53c
Compare
I was just going through the documentation and found, that we've documented the So this means that this is no longer a simply a braking change, but also a bug fix. |
Signed-off-by: Itay Grudev <[email protected]>
@itay-grudev is there any release date for this? |
@mjtrangoni I apologise about the delay. I wanted to merge some other work first and then this, as this would require a minor patch due to breaking changes. If I get everything reviewed next week, I'll merge it. |
P.S. The moment I update this branch in a moment, the test should fail due to the test suite that I just added to the chart. The test will need to be updated, but I'll take care of that. I have edit access to your branch. |
…get propagated Signed-off-by: Itay Grudev <[email protected]>
Signed-off-by: Itay Grudev <[email protected]>
Hi,
This is a BREAKING CHANGE, and fixes #308.
IMHO, we should go with this kind of fixes now and taking into account that postgresql has a lot of configurations defined here, not only parameters, this fixes the way it will be handled.
Thank you!
PS: I had to remove one trailing space for the the CI to success, but in a separate commit so that you can remove it easily