feat(cluster): Make roles configurable #247

gpothier · 2024-04-04T03:47:05Z

This makes it possible to configure roles using the chart by adding an array in cluster.roles in values.yaml. The content of the array are taken as is and used as .spec.managed.roles.

This is a follow up to PR #226, which ended up with conflicts, so I started a new one.

In this new PR I signed off my changes, and I ran make schema docs.

The rationale for adding the with inside instead of outside managed: in cluster.yaml is that in case it is needed at some point to bring other things into managed, we would have to put an if with several conditions outside, and several ifs inside in order to avoid the empty element. I did try the chart without specifying roles to check if the empty managed was a problem, and there was no problem.

Closes #201

Signed-off-by: Guillaume Pothier <[email protected]>

Note: I manually removed a footer that said something like "autogenerated by...", as it is not in the original version. I don't know why my version of helm-docs added it Signed-off-by: Guillaume Pothier <[email protected]>

charts/cluster/templates/cluster.yaml

itay-grudev · 2024-04-08T20:49:51Z

I'm sorry for the late response. Just one comment. Otherwise looks good.

…21335) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cloudnative-pg](https://cloudnative-pg.io) ([source](https://togithub.com/cloudnative-pg/charts)) | minor | `0.20.2` -> `0.21.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>cloudnative-pg/charts (cloudnative-pg)</summary> ### [`v0.21.0`](https://togithub.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.0) [Compare Source](https://togithub.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.20.2...cloudnative-pg-v0.21.0) CloudNativePG Operator Helm Chart #### What's Changed - feat(cluster): Make roles configurable by [@gpothier](https://togithub.com/gpothier) in [https://github.com/cloudnative-pg/charts/pull/247](https://togithub.com/cloudnative-pg/charts/pull/247) - chore(deps): update actions/checkout action to v4.1.3 by [@renovate](https://togithub.com/renovate) in [https://github.com/cloudnative-pg/charts/pull/260](https://togithub.com/cloudnative-pg/charts/pull/260) - chore(deps): update helm/kind-action action to v1.10.0 by [@renovate](https://togithub.com/renovate) in [https://github.com/cloudnative-pg/charts/pull/261](https://togithub.com/cloudnative-pg/charts/pull/261) - Release cloudnative-pg-v0.21.0 by [@github-actions](https://togithub.com/github-actions) in [https://github.com/cloudnative-pg/charts/pull/266](https://togithub.com/cloudnative-pg/charts/pull/266) #### New Contributors - [@gpothier](https://togithub.com/gpothier) made their first contribution in [https://github.com/cloudnative-pg/charts/pull/247](https://togithub.com/cloudnative-pg/charts/pull/247) **Full Changelog**: cloudnative-pg/charts@cluster-v0.0.8...cloudnative-pg-v0.21.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cloudnative-pg](https://cloudnative-pg.io) ([source](https://github.com/cloudnative-pg/charts)) | minor | `0.20.2` -> `0.21.0` | --- ### Release Notes <details> <summary>cloudnative-pg/charts (cloudnative-pg)</summary> ### [`v0.21.0`](https://github.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.0) [Compare Source](cloudnative-pg/charts@cloudnative-pg-v0.20.2...cloudnative-pg-v0.21.0) CloudNativePG Operator Helm Chart #### What's Changed - feat(cluster): Make roles configurable by [@gpothier](https://github.com/gpothier) in cloudnative-pg/charts#247 - chore(deps): update actions/checkout action to v4.1.3 by [@renovate](https://github.com/renovate) in cloudnative-pg/charts#260 - chore(deps): update helm/kind-action action to v1.10.0 by [@renovate](https://github.com/renovate) in cloudnative-pg/charts#261 - Release cloudnative-pg-v0.21.0 by [@github-actions](https://github.com/github-actions) in cloudnative-pg/charts#266 #### New Contributors - [@gpothier](https://github.com/gpothier) made their first contribution in cloudnative-pg/charts#247 **Full Changelog**: cloudnative-pg/charts@cluster-v0.0.8...cloudnative-pg-v0.21.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.internal/nrdufour/home-ops/pulls/457 Co-authored-by: Renovate <[email protected]> Co-committed-by: Renovate <[email protected]>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cloudnative-pg](https://cloudnative-pg.io) ([source](https://togithub.com/cloudnative-pg/charts)) | minor | `0.20.2` -> `0.21.0` | --- ### Release Notes <details> <summary>cloudnative-pg/charts (cloudnative-pg)</summary> ### [`v0.21.0`](https://togithub.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.0) [Compare Source](https://togithub.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.20.2...cloudnative-pg-v0.21.0) CloudNativePG Operator Helm Chart #### What's Changed - feat(cluster): Make roles configurable by [@gpothier](https://togithub.com/gpothier) in [https://github.com/cloudnative-pg/charts/pull/247](https://togithub.com/cloudnative-pg/charts/pull/247) - chore(deps): update actions/checkout action to v4.1.3 by [@renovate](https://togithub.com/renovate) in [https://github.com/cloudnative-pg/charts/pull/260](https://togithub.com/cloudnative-pg/charts/pull/260) - chore(deps): update helm/kind-action action to v1.10.0 by [@renovate](https://togithub.com/renovate) in [https://github.com/cloudnative-pg/charts/pull/261](https://togithub.com/cloudnative-pg/charts/pull/261) - Release cloudnative-pg-v0.21.0 by [@github-actions](https://togithub.com/github-actions) in [https://github.com/cloudnative-pg/charts/pull/266](https://togithub.com/cloudnative-pg/charts/pull/266) #### New Contributors - [@gpothier](https://togithub.com/gpothier) made their first contribution in [https://github.com/cloudnative-pg/charts/pull/247](https://togithub.com/cloudnative-pg/charts/pull/247) **Full Changelog**: cloudnative-pg/charts@cluster-v0.0.8...cloudnative-pg-v0.21.0 </details>  Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cloudnative-pg](https://cloudnative-pg.io) ([source](https://togithub.com/cloudnative-pg/charts)) | minor | `0.20.2` -> `0.21.1` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>cloudnative-pg/charts (cloudnative-pg)</summary> ### [`v0.21.1`](https://togithub.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.1) [Compare Source](https://togithub.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.21.0...cloudnative-pg-v0.21.1) CloudNativePG Operator Helm Chart #### What's Changed - fix: Bump chart dependency grafana-dashboards to version 0.0.2 by [@dexter136](https://togithub.com/dexter136) in [https://github.com/cloudnative-pg/charts/pull/270](https://togithub.com/cloudnative-pg/charts/pull/270) #### New Contributors - [@dexter136](https://togithub.com/dexter136) made their first contribution in [https://github.com/cloudnative-pg/charts/pull/270](https://togithub.com/cloudnative-pg/charts/pull/270) **Full Changelog**: cloudnative-pg/charts@cloudnative-pg-v0.21.0...cloudnative-pg-v0.21.1 ### [`v0.21.0`](https://togithub.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.0) [Compare Source](https://togithub.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.20.2...cloudnative-pg-v0.21.0) CloudNativePG Operator Helm Chart #### What's Changed - feat(cluster): Make roles configurable by [@gpothier](https://togithub.com/gpothier) in [https://github.com/cloudnative-pg/charts/pull/247](https://togithub.com/cloudnative-pg/charts/pull/247) - chore(deps): update actions/checkout action to v4.1.3 by [@renovate](https://togithub.com/renovate) in [https://github.com/cloudnative-pg/charts/pull/260](https://togithub.com/cloudnative-pg/charts/pull/260) - chore(deps): update helm/kind-action action to v1.10.0 by [@renovate](https://togithub.com/renovate) in [https://github.com/cloudnative-pg/charts/pull/261](https://togithub.com/cloudnative-pg/charts/pull/261) - Release cloudnative-pg-v0.21.0 by [@github-actions](https://togithub.com/github-actions) in [https://github.com/cloudnative-pg/charts/pull/266](https://togithub.com/cloudnative-pg/charts/pull/266) #### New Contributors - [@gpothier](https://togithub.com/gpothier) made their first contribution in [https://github.com/cloudnative-pg/charts/pull/247](https://togithub.com/cloudnative-pg/charts/pull/247) **Full Changelog**: cloudnative-pg/charts@cluster-v0.0.8...cloudnative-pg-v0.21.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cloudnative-pg](https://cloudnative-pg.io) ([source](https://togithub.com/cloudnative-pg/charts)) | minor | `0.20.2` -> `0.21.1` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>cloudnative-pg/charts (cloudnative-pg)</summary> ### [`v0.21.1`](https://togithub.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.1) [Compare Source](https://togithub.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.21.0...cloudnative-pg-v0.21.1) CloudNativePG Operator Helm Chart #### What's Changed - fix: Bump chart dependency grafana-dashboards to version 0.0.2 by [@dexter136](https://togithub.com/dexter136) in [https://github.com/cloudnative-pg/charts/pull/270](https://togithub.com/cloudnative-pg/charts/pull/270) #### New Contributors - [@dexter136](https://togithub.com/dexter136) made their first contribution in [https://github.com/cloudnative-pg/charts/pull/270](https://togithub.com/cloudnative-pg/charts/pull/270) **Full Changelog**: cloudnative-pg/charts@cloudnative-pg-v0.21.0...cloudnative-pg-v0.21.1 ### [`v0.21.0`](https://togithub.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.0) [Compare Source](https://togithub.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.20.2...cloudnative-pg-v0.21.0) CloudNativePG Operator Helm Chart #### What's Changed - feat(cluster): Make roles configurable by [@gpothier](https://togithub.com/gpothier) in [https://github.com/cloudnative-pg/charts/pull/247](https://togithub.com/cloudnative-pg/charts/pull/247) - chore(deps): update actions/checkout action to v4.1.3 by [@renovate](https://togithub.com/renovate) in [https://github.com/cloudnative-pg/charts/pull/260](https://togithub.com/cloudnative-pg/charts/pull/260) - chore(deps): update helm/kind-action action to v1.10.0 by [@renovate](https://togithub.com/renovate) in [https://github.com/cloudnative-pg/charts/pull/261](https://togithub.com/cloudnative-pg/charts/pull/261) - Release cloudnative-pg-v0.21.0 by [@github-actions](https://togithub.com/github-actions) in [https://github.com/cloudnative-pg/charts/pull/266](https://togithub.com/cloudnative-pg/charts/pull/266) #### New Contributors - [@gpothier](https://togithub.com/gpothier) made their first contribution in [https://github.com/cloudnative-pg/charts/pull/247](https://togithub.com/cloudnative-pg/charts/pull/247) **Full Changelog**: cloudnative-pg/charts@cluster-v0.0.8...cloudnative-pg-v0.21.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>

gpothier added 2 commits April 4, 2024 00:34

Make roles configurable

70bd926

Signed-off-by: Guillaume Pothier <[email protected]>

Update README (through make schema docs)

54764b6

Note: I manually removed a footer that said something like "autogenerated by...", as it is not in the original version. I don't know why my version of helm-docs added it Signed-off-by: Guillaume Pothier <[email protected]>

gpothier requested a review from itay-grudev as a code owner April 4, 2024 03:47

gpothier mentioned this pull request Apr 4, 2024

Add support for declarative role management #201

Closed

itay-grudev requested changes Apr 8, 2024

View reviewed changes

charts/cluster/templates/cluster.yaml Show resolved Hide resolved

gpothier mentioned this pull request Apr 19, 2024

[Feature]: Allow to specify roles when using the "Cluster" chart cloudnative-pg/cloudnative-pg#4156

Open

2 tasks

Merge branch 'main' into rolestake2/201

8f32f0c

itay-grudev approved these changes Apr 20, 2024

View reviewed changes

itay-grudev merged commit 2728793 into cloudnative-pg:main Apr 20, 2024
4 checks passed

itay-grudev added the chart( cluster ) Related to the cluster chart label May 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cluster): Make roles configurable #247

feat(cluster): Make roles configurable #247

gpothier commented Apr 4, 2024

itay-grudev commented Apr 8, 2024 •

edited

Loading

feat(cluster): Make roles configurable #247

feat(cluster): Make roles configurable #247

Conversation

gpothier commented Apr 4, 2024

itay-grudev commented Apr 8, 2024 • edited Loading

itay-grudev commented Apr 8, 2024 •

edited

Loading