Fix comments in BPM test (cmu-db#175)

jkosh44 · web-flow · commit 2d12c1cec60d · 2021-09-14T18:23:25.000-04:00
diff --git a/test/buffer/buffer_pool_manager_instance_test.cpp b/test/buffer/buffer_pool_manager_instance_test.cpp
@@ -63,8 +63,7 @@ TEST(BufferPoolManagerInstanceTest, DISABLED_BinaryDataTest) {
     EXPECT_EQ(nullptr, bpm->NewPage(&page_id_temp));
   }
 
-  // Scenario: After unpinning pages {0, 1, 2, 3, 4} and pinning another 4 new pages,
-  // there would still be one cache frame left for reading page 0.
+  // Scenario: After unpinning pages {0, 1, 2, 3, 4} we should be able to create 5 new pages
   for (int i = 0; i < 5; ++i) {
     EXPECT_EQ(true, bpm->UnpinPage(i, true));
     bpm->FlushPage(i);
diff --git a/test/buffer/parallel_buffer_pool_manager_test.cpp b/test/buffer/parallel_buffer_pool_manager_test.cpp
@@ -64,8 +64,7 @@ TEST(ParallelBufferPoolManagerTest, DISABLED_BinaryDataTest) {
     EXPECT_EQ(nullptr, bpm->NewPage(&page_id_temp));
   }
 
-  // Scenario: After unpinning pages {0, 1, 2, 3, 4} and pinning another 4 new pages,
-  // there would still be one cache frame left for reading page 0.
+  // Scenario: After unpinning pages {0, 1, 2, 3, 4} we should be able to create 5 new pages
   for (int i = 0; i < 5; ++i) {
     EXPECT_EQ(true, bpm->UnpinPage(i, true));
     bpm->FlushPage(i);
@@ -74,6 +73,7 @@ TEST(ParallelBufferPoolManagerTest, DISABLED_BinaryDataTest) {
     EXPECT_NE(nullptr, bpm->NewPage(&page_id_temp));
     bpm->UnpinPage(page_id_temp, false);
   }
+
   // Scenario: We should be able to fetch the data we wrote a while ago.
   page0 = bpm->FetchPage(0);
   EXPECT_EQ(0, memcmp(page0->GetData(), random_binary_data, PAGE_SIZE));

Original file line number	Diff line number	Diff line change
`@@ -63,8 +63,7 @@ TEST(BufferPoolManagerInstanceTest, DISABLED_BinaryDataTest) {`
`63`	`63`	`EXPECT_EQ(nullptr, bpm->NewPage(&page_id_temp));`
`64`	`64`	`}`
`65`	`65`
`66`		`- // Scenario: After unpinning pages {0, 1, 2, 3, 4} and pinning another 4 new pages,`
`67`		`- // there would still be one cache frame left for reading page 0.`
	`66`	`+ // Scenario: After unpinning pages {0, 1, 2, 3, 4} we should be able to create 5 new pages`
`68`	`67`	`for (int i = 0; i < 5; ++i) {`
`69`	`68`	`EXPECT_EQ(true, bpm->UnpinPage(i, true));`
`70`	`69`	`bpm->FlushPage(i);`