Continue support for creating a pg.Pool from another instance’s options (brianc#2076)

charmander · brianc · commit 05c76651382d · 2020-01-28T10:39:59.000-06:00
* Add failing test for creating a `BoundPool` from another instance&rsquo;s settings

* Continue support for creating a pg.Pool from another instance&rsquo;s options

by dropping the requirement for the `password` property to be enumerable.
diff --git a/packages/pg/lib/index.js b/packages/pg/lib/index.js
@@ -15,8 +15,7 @@ var Pool = require('pg-pool')
 const poolFactory = (Client) => {
   return class BoundPool extends Pool {
     constructor (options) {
-      var config = Object.assign({ Client: Client }, options)
-      super(config)
+      super(options, Client)
     }
   }
 }
diff --git a/packages/pg/test/unit/connection-pool/configuration-tests.js b/packages/pg/test/unit/connection-pool/configuration-tests.js
@@ -0,0 +1,14 @@
+'use strict'
+
+const assert = require('assert')
+const helper = require('../test-helper')
+
+test('pool with copied settings includes password', () => {
+  const original = new helper.pg.Pool({
+    password: 'original',
+  })
+
+  const copy = new helper.pg.Pool(original.options)
+
+  assert.equal(copy.options.password, 'original')
+})

Original file line number	Diff line number	Diff line change
`@@ -15,8 +15,7 @@ var Pool = require('pg-pool')`
`15`	`15`	`const poolFactory = (Client) => {`
`16`	`16`	`return class BoundPool extends Pool {`
`17`	`17`	`constructor (options) {`
`18`		`- var config = Object.assign({ Client: Client }, options)`
`19`		`- super(config)`
	`18`	`+ super(options, Client)`
`20`	`19`	`}`
`21`	`20`	`}`
`22`	`21`	`}`