Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): add Catppuccin #43

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

sgoudham
Copy link
Contributor

@sgoudham sgoudham commented Dec 12, 2023

Hey 👋
First of all, this is a lovely project, thanks for creating it!

I'm just following up on @maaslalani's discord message, and adding Catppuccin alongside the default themes.

P.S I'm not a go programmer™ so please let me know if I've changed something that I shouldn't have!

@sgoudham
Copy link
Contributor Author

One thing I wanted to clarify, can the colours for the actions (see screenshot below) be modified?

image

I wasn't able to find obvious keys for the next and back text so it's quite harsh on Catppuccin's darker flavours.

@sgoudham sgoudham force-pushed the feat/add-catppuccin branch from 7d318cd to 74a006d Compare December 12, 2023 01:28
@sgoudham sgoudham marked this pull request as ready for review December 12, 2023 02:09
@meowgorithm
Copy link
Member

One thing I wanted to clarify, can the colours for the actions (see screenshot below) be modified?

I wasn't able to find obvious keys for the next and back text so it's quite harsh on Catppuccin's darker flavours.

Hey, @sgoudham! You sure can . It's Help here on FieldStyles:

https://pkg.go.dev/github.com/charmbracelet/huh#FieldStyles

And then the help definition is:

https://pkg.go.dev/github.com/charmbracelet/[email protected]/help#Styles

Let us know if you have more questions. We’re really excited about this Catpuccin theme!

@maaslalani
Copy link
Contributor

maaslalani commented Dec 12, 2023

Hey @sgoudham, just a heads up we moved the Help styles to be directly on the Theme instead of embedded within the FieldStyles!

@sgoudham sgoudham force-pushed the feat/add-catppuccin branch from be7baaa to c986696 Compare December 12, 2023 19:34
@sgoudham sgoudham force-pushed the feat/add-catppuccin branch from c986696 to 9154aa4 Compare December 12, 2023 19:41
@sgoudham
Copy link
Contributor Author

Thanks for the heads up @maaslalani

I've now styled the Help section so the Catppuccin theme now looks like the following:

Light Dark

Think that's everything now!

@maaslalani
Copy link
Contributor

Thanks so much! This looks perfect!

@maaslalani maaslalani merged commit e9c59d7 into charmbracelet:main Dec 12, 2023
@sgoudham sgoudham deleted the feat/add-catppuccin branch December 12, 2023 19:46
@meowgorithm
Copy link
Member

Holy moly that looks good, @sgoudham. Nice work!

@sgoudham
Copy link
Contributor Author

Thank you both for making my first contribution into Charm so easy and fun! ❤️

@maaslalani
Copy link
Contributor

Thank you for making such an awesome contribution!

We just released v0.2.0 to include the new theme: https://github.com/charmbracelet/huh/releases/tag/v0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants