fix: remove dollar sign on command shells #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reza Rachmanuddin <[email protected]>
retry19
force-pushed
the
feature/remove-dollar-sign-from-terminal-commands
branch
from
fdc39eb
to
965408c
Compare
Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
vchrombie
force-pushed
the
feature/remove-dollar-sign-from-terminal-commands
branch
from
4d5c136
to
5a4cc14
Compare
|
Thanks for your PR @retry19, I added a commit to revert a few changes (partial changes related to virtual environments, I would prefer to have them still because they would cause confusion if not there) and added additional changes (removing the $ in the repository). The PR now looks great, thanks for your help. I am going to merge it. |
|
@vchrombie thanks for add more changes 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove
$in every command shellScreenshot
Related issue
Closes #214