-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Column 'event' cannot be null for long names events #201
Open
TopSolid-DaA
wants to merge
36
commits into
MOODLE_311_STABLE
Choose a base branch
from
MOODLE_35_STABLE
base: MOODLE_311_STABLE
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostgreSQL has a limit of 65535 parameters and this was exceeded causing the task to fail. MySQL has does not have a parameter limit, but there is a sysvar_max_allowed_packet which would fail out once exceeded.
Fix for the cleanup_history task with a large number of parameters
HTTP action and Stringcompare filter updates.
Issue when upgrading from a lower version - started from 01950e6
Add missing foreign key for 'stepconfigid' upgrades
- Add new section for settings related to the workflow queue. - The queue limit has been moved out from being a constant, to a configurable admin setting.
By default these are NULL, and when set they are a currently a string value, so this should still work as intended for expected values, and should fix up the display in the history table
…d-history-display Add configurable task limits and history display
[#164] Fix Unexpected Moodle Internal errors/warnings in CI
* Add support to run webservice functions internally - Will run on behalf of the designated user / in their context - Will currently accept a JSON blob in the parameters, similar to the HTTP POST action. * Add several adjustments to username handling and reducing side-effects - Add handling to set user back to previous after running the step which should avoid unintended side affects - Update handling of username so that if it's not provided, it uses the main admin user by default - Also refactored the code a bit to make it easier to see what's happening at a higher level (from the execute method) * Add custom validation support to all steps This should allow one to verify certain fields for steps to match what is expected, if the functionality cannot be done from the standard formlib checks alone * Adjust lang string & form to indicate behaviour of not setting username * Add custom validation in webservice action step - Validates username must exist for user selected, if set - Validates the function parameters that would be called. Note that due to templating, this will change the field templated to a ZERO, which might not be as expected. The only time this may not be what you want is probably if you are trying to add a field which is dynamic based on the previous input's value (possible but not common) * Fix PHPCS errors * Add tests for webservice action step * Fix more PHPCS issues (line too long) * Adjust for backwards compatibility with JSON_THROW_ON_ERROR This will now default to an array format (which is a valid input for a webservice function call) if the user did not provide parameters. Otherwise, it will attempt to decode the json and if it's still NULL, something went wrong. * Fix more unrelated PHPCS issues * Ensure parent form validation carries through also * Add handling to transform the data per step defined in each step class - In particular adding a transform for the webservice action step to prettify the 'params' (JSON input) so it is more readable/managable the next time it is loaded. * Fix tests using assertStringContainsString for backward compatibility * Version bump
…ranches-for-35 Add reusable workflow ci and update support branches
Improved anonymous execution user handling
Ensure return value is always of type array
This prevents the lastaccess time from being updated, and checks for both lastlogin and lastaccess timestamps to ensure they are unchanged after running the webservice action Improves upon #182
…actions fix: issue where the user executing the web service was being updated
Fixed improper handling of transactions in webservice steps and logging
Updated history filter to allow 0th step to be handled
Normally taking 135ms to complete, drops down to 0.4ms
There's a lot of failing checks due to phpdoc, and we're gradually cutting across this plugin (considered legacy) to tool_dataflows
perf(db): add index to improve query times
thanks @TopSolid can you please rebase this, I cannot see what code you are trying to submit? |
Issue#203 Insert tool_trigger_events id into event other data
issue #209: allow different HTTP methods for http_post_action_step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moodle requires to use setType(). And there is not setType() for event field.
Therefore, it allows to save only events with small name, which is not working for IntelliCart Events, 'cause we have pretty long names (e.g., "IntelliCart: IntelliCart product checkout").
Add at 90 this line code fixes this issue in /classes/edit_form.php
$mform->setType('eventtomonitor', PARAM_TEXT);
Check here for further details
#200