-
Notifications
You must be signed in to change notification settings - Fork 3
Documentation - Centralized Telescope: Parameters #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
747148f to
57b2b07
Compare
0c5f1b6 to
e7a719e
Compare
Co-authored-by: Tolik Zinovyev <[email protected]>
rrtoledo
previously approved these changes
Feb 10, 2025
Collaborator
rrtoledo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added a few suggestions to capitalize b for the DFS bounds
Co-authored-by: Raphael <[email protected]>
6 tasks
rrtoledo
approved these changes
Mar 31, 2025
Collaborator
rrtoledo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Documentation of parameter setup for the centralized telescope.
This PR includes:
src/centralized_telescope/params.rsis updated to include doc links to related sections.Pre-submit checklist
Issue(s)
Blocked by #142
Closes #102