Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(live-update): resetOnUpdate configuration option not working #256

Open
5 of 24 tasks
luisbytes opened this issue Aug 10, 2024 · 3 comments
Open
5 of 24 tasks

bug(live-update): resetOnUpdate configuration option not working #256

luisbytes opened this issue Aug 10, 2024 · 3 comments
Labels
bounty bug/fix Something isn't working package: live-update platform: android Android platform $50

Comments

@luisbytes
Copy link

luisbytes commented Aug 10, 2024 •
edited by robingenz
Loading

Plugin(s)

  • Android Foreground Service
  • Android Battery Optimization
  • App Update
  • Background Task
  • Badge
  • Bluetooth Low Energy
  • Cloudinary
  • Datetime Picker
  • File Compressor
  • File Opener
  • File Picker
  • Live Update
  • Managed Configurations
  • NFC
  • Photo Editor
  • Printer
  • Screen Orientation
  • Zip

Version

6.3.0

Platform(s)

  • Android
  • iOS
  • Web

Current behavior

The resetOnUpdate configuration option does not seem to work. Regardless of the value of resetOnUpdate, the application is always reset to the default bundle during a native update.

Expected behavior

The application should not be reset to the default bundle if resetOnUpdate is set to false.

Reproduction

Steps to reproduce

  1. Add resetOnUpdate in false
  2. Install a new native version

Other information

No response

Capacitor doctor

💊 Capacitor Doctor 💊

Latest Dependencies:

@capacitor/cli: 6.1.2
@capacitor/core: 6.1.2
@capacitor/android: 6.1.2
@capacitor/ios: 6.1.2

Installed Dependencies:

@capacitor/ios: not installed
@capacitor/cli: 6.1.2
@capacitor/core: 6.1.2
@capacitor/android: 6.1.2

Before submitting

  • I have read and followed the bug report guidelines.
  • I have attached links to possibly related issues and discussions.
  • I understand that incomplete issues (e.g. without reproduction) are closed.
@luisbytes luisbytes added bug/fix Something isn't working needs: triage labels Aug 10, 2024
@luisbytes luisbytes changed the title bug: resetOnUpdate not working bug(live-update): resetOnUpdate not working Aug 10, 2024
@robingenz
Copy link
Member

A reset is only performed if resetOnUpdate is set to true, see

capacitor-plugins/packages/live-update/android/src/main/java/io/capawesome/capacitorjs/plugins/liveupdate/LiveUpdate.java

Line 82 in 761f655

if (wasUpdated() && config.getResetOnUpdate()) {

Did you run npx cap sync after updating the config?

@luisbytes
Copy link
Author

A reset is only performed if resetOnUpdate is set to true, see

capacitor-plugins/packages/live-update/android/src/main/java/io/capawesome/capacitorjs/plugins/liveupdate/LiveUpdate.java

Line 82 in 761f655

if (wasUpdated() && config.getResetOnUpdate()) {

Did you run npx cap sync after updating the config?

Yes, I put logs to print the configuration that was arriving and everything was correct, but every time I install a new apk it changes to the buildin

@robingenz
Copy link
Member

robingenz commented Aug 11, 2024 •
edited
Loading

I've just tested it and i can reproduce your issue. However, it is not the plugin that performs this reset but it seems to be Capacitor itself. I will have to take a closer look at this. Feel free to look into it yourself and create a PR.

EDIT: I set a bounty of $50 to solve the issue. I am looking for a clean solution, not a workaround. The first step would be to identify the cause of this behavior. Let me know if anyone wants to work on this.

@robingenz robingenz changed the title bug(live-update): resetOnUpdate not working bug(live-update): resetOnUpdate configuration option not working Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty bug/fix Something isn't working package: live-update platform: android Android platform $50
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robingenz @luisbytes