Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ggplot2 aes warnings #242

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Remove ggplot2 aes warnings #242

merged 2 commits into from
Dec 20, 2023

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Dec 15, 2023 •
edited
Loading

Fix #235.

Approach:

look at whatever compute groups return, and add anything else to dropped aesthetics.

I also changed the limits since the current limits show an empty plot. https://business-science.github.io/tidyquant/reference/geom_bbands.html#ref-examples

@olivroy olivroy mentioned this pull request Dec 15, 2023
Closed
@olivroy
Copy link
Contributor Author

olivroy commented Dec 20, 2023

@mdancho84 , whenever you have time, you can merge the 2 pull requests, as it solves errors !

@mdancho84 mdancho84 merged commit 3e6814b into business-science:master Dec 20, 2023
9 checks passed
@olivroy olivroy deleted the ggplot branch December 20, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tidyquant::geom_candlestick
2 participants
@olivroy @mdancho84