Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php app/console braincrafted:bootstrap:generate puts custom variables.less at top, should be at bottom #309

Closed
tmiller02 opened this issue Oct 9, 2014 · 4 comments
Closed

php app/console braincrafted:bootstrap:generate puts custom variables.less at top, should be at bottom #309

tmiller02 opened this issue Oct 9, 2014 · 4 comments
Assignees
@florianeckerstorfer
Labels
Bug
Milestone
2.1.1

Comments

@tmiller02
Copy link

Running php app/console braincrafted:bootstrap:generate generates the bootstrap.less file successfully, but it includes my custom variables.less file right at the top.

I think the correct approach is to import the standard bootstrap assets first, then define the custom values with less, otherwise the custom variables will be overwritten with the defaults.
@florianeckerstorfer
Copy link
Member

You're right, the current approach is a little bit wrong, since it only includes your custom variables.less and not the default one.

@florianeckerstorfer florianeckerstorfer added this to the 2.1.1 milestone Oct 9, 2014
@florianeckerstorfer florianeckerstorfer self-assigned this Oct 9, 2014
@waltercruz
Copy link

sorry if this is the wrong place to ask: is the support for customizing the sass version of bootstrap planned?

@florianeckerstorfer
Copy link
Member

@waltercruz That should be possible right now? What do you want to do?

@waltercruz
Copy link

I wanted to customize my sass bootstrap, passing my own variables. It's already working. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florianeckerstorfer florianeckerstorfer

Labels
Bug
Projects
None yet
Milestone
2.1.1
Development

No branches or pull requests
3 participants
@waltercruz @florianeckerstorfer @tmiller02