Skip to content

fix(useModalOrchestrator): circular dependency #2874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
VividLemon merged 1 commit into from
Oct 7, 2025
Merged

fix(useModalOrchestrator): circular dependency #2874

VividLemon merged 1 commit into from
Oct 7, 2025

Conversation

@VividLemon
Copy link
Member

@VividLemon VividLemon commented Oct 7, 2025 •
edited by coderabbitai bot
Loading

Describe the PR

A clear and concise description of what the pull request does.

Small replication

A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

Summary by CodeRabbit

  • Refactor
    • Streamlined internal module imports for the modal component to improve build reliability and potential tree-shaking.
    • No changes to functionality, UI, or user workflows.

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Oct 7, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@VividLemon VividLemon requested a review from Copilot October 7, 2025 18:26
Copilot AI reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a circular dependency issue in the useModalOrchestrator component by modifying the import path for the useModal composable from a barrel export to a direct import.

  • Replaced barrel import with specific file import to avoid circular dependency

@coderabbitai
Copy link

coderabbitai bot commented Oct 7, 2025 •
edited
Loading

Walkthrough

Adjusted the import path for useModal in BModalOrchestrator.vue from a barrel export to a direct module import. No functional or control-flow changes.

Changes

Cohort / File(s) Summary
Import path refactor
packages/bootstrap-vue-next/src/components/BModal/BModalOrchestrator.vue		 Updated import from ../../composables to ../../composables/useModal; no other code changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nudged a path by just a hair,
From barrel wide to module fair.
No ripples stirred the modal sea—
Just tidier tracks for imports to be.
A hop, a skip, a squeak of glee! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description only contains unmodified template placeholders without any details about the actual changes, missing a concrete “Describe the PR” summary, replication details, and checklist selections, so it lacks the required information and does not reflect the code modifications. Please replace the placeholder text with a concise summary of the import change and its purpose, provide or link to a replication example if available, and update the PR checklist by selecting the appropriate change type and confirming compliance with conventional commits.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly summarizes the primary change by indicating a fix to the circular dependency in useModalOrchestrator using conventional commit format, which matches the actual change of updating import resolution to avoid circular imports in BModalOrchestrator.vue. It's concise, specific, and fully relates to the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch VividLemon-patch-1
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 720daf8 and f49419f.

📒 Files selected for processing (1)
  • packages/bootstrap-vue-next/src/components/BModal/BModalOrchestrator.vue (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
packages/bootstrap-vue-next/src/components/**

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Create and modify Vue components only under packages/bootstrap-vue-next/src/components/

Files:

  • packages/bootstrap-vue-next/src/components/BModal/BModalOrchestrator.vue
packages/bootstrap-vue-next/src/components/**/*.vue

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Keep component-specific styles within their respective .vue single-file components

Files:

  • packages/bootstrap-vue-next/src/components/BModal/BModalOrchestrator.vue
🧠 Learnings (1)
📚 Learning: 2025-09-30T23:57:21.526Z 
Learnt from: dwgray
PR: bootstrap-vue-next/bootstrap-vue-next#2866
File: apps/docs/src/docs/components/demo/ModalModel.vue:11-15
Timestamp: 2025-09-30T23:57:21.526Z
Learning: The bootstrap-vue-next documentation project uses unplugin-vue-components to automatically resolve and import Vue components like BModal, BButton, etc. Explicit imports for these components in script sections are not required.

Applied to files:

  • packages/bootstrap-vue-next/src/components/BModal/BModalOrchestrator.vue
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (1)
packages/bootstrap-vue-next/src/components/BModal/BModalOrchestrator.vue (1)

10-10: Approve direct import change

Replaces barrel export to break circular dependencies, matching the existing import pattern; no other barrel imports of useModal remain. Ensure build/tests pass to confirm the circular dependency is resolved.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@VividLemon VividLemon merged commit c0bf12f into main Oct 7, 2025
3 of 4 checks passed
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
Merged
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Oct 11, 2025
@xvaara
Merge remote-tracking branch 'upstream/main'
c44eef0 
* upstream/main:
  chore: release main (bootstrap-vue-next#2868)
  fix(useModalOrchestrator): circular dependency (bootstrap-vue-next#2874)
  docs(BModal): Parity pass (bootstrap-vue-next#2866)
  docs: Enable directly loading examples into StackBlitz (bootstrap-vue-next#2869)
  fix(BApp): wrap our test app in BApp in main.ts to enable easy verification of useModal, etc. (bootstrap-vue-next#2865)
  export useScrollLock() (bootstrap-vue-next#2854)
  chore: release main (bootstrap-vue-next#2858)
  fix(BToggle): stop looking for missing targets after directive is unmounted (bootstrap-vue-next#2857)
  chore: release main (bootstrap-vue-next#2851)
  Fix modal transition delays by making TransitionGroup name conditional (bootstrap-vue-next#2845)
  chore: release main (bootstrap-vue-next#2842)
  fix(BTable): events being wrongly stopped when sent from elements inside TRs (bootstrap-vue-next#2841)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VividLemon