chore(compat): make tabs properly filter in Vue 3

xanf · xanf · commit ea1269f04596 · 2022-10-25T00:35:54.000+03:00
* correctly handle `null` inside children
* fix test
diff --git a/src/components/tabs/tabs.js b/src/components/tabs/tabs.js
@@ -357,7 +357,7 @@ export const BTabs = /*#__PURE__*/ Vue.extend({
     },
     getTabs() {
       const $tabs = this.registeredTabs.filter(
-        $tab => $tab.$children.filter($t => $t._isTab).length === 0
+        $tab => $tab.$children.filter($t => $t && $t._isTab).length === 0
       )
 
       // DOM Order of Tabs
diff --git a/src/components/tabs/tabs.spec.js b/src/components/tabs/tabs.spec.js
@@ -35,7 +35,12 @@ describe('tabs', () => {
   it('has correct card classes when prop card is true', async () => {
     const wrapper = mount(BTabs, {
       propsData: { card: true },
-      slots: { default: [BTab, BTab, BTab] }
+      slots: {
+        default: {
+          components: { BTab },
+          template: '<div><b-tab /><b-tab /><b-tab /></div>'
+        }
+      }
     })
 
     await waitNT(wrapper.vm)
@@ -55,7 +60,12 @@ describe('tabs', () => {
   it('has correct card classes when props card and vertical are true', async () => {
     const wrapper = mount(BTabs, {
       propsData: { card: true, vertical: true },
-      slots: { default: [BTab, BTab, BTab] }
+      slots: {
+        default: {
+          components: { BTab },
+          template: '<div><b-tab /><b-tab /><b-tab /></div>'
+        }
+      }
     })
 
     await waitNT(wrapper.vm)
@@ -84,7 +94,12 @@ describe('tabs', () => {
     const tabIndex = 1
     const wrapper = mount(BTabs, {
       propsData: { value: tabIndex },
-      slots: { default: [BTab, BTab, BTab] }
+      slots: {
+        default: {
+          components: { BTab },
+          template: '<div><b-tab /><b-tab /><b-tab /></div>'
+        }
+      }
     })
 
     await waitNT(wrapper.vm)

Original file line number	Diff line number	Diff line change
`@@ -357,7 +357,7 @@ export const BTabs = /#__PURE__/ Vue.extend({`
`357`	`357`	`},`
`358`	`358`	`getTabs() {`
`359`	`359`	`const $tabs = this.registeredTabs.filter(`
`360`		`- $tab => $tab.$children.filter($t => $t._isTab).length === 0`
	`360`	`+ $tab => $tab.$children.filter($t => $t && $t._isTab).length === 0`
`361`	`361`	`)`
`362`	`362`
`363`	`363`	`// DOM Order of Tabs`